Re: [RFC net-next 1/1] net: sched: fix hw filter offload in tc flower

2019-04-05 Thread Vlad Buslov
On Thu 04 Apr 2019 at 14:03, John Hurley wrote: > On Wed, Apr 3, 2019 at 5:42 PM Vlad Buslov wrote: >> >> >> On Wed 03 Apr 2019 at 15:37, John Hurley wrote: >> > Recent refactoring of fl_change aims to use the classifier spinlock to >> > avoid the need for rtnl lock. In doing so, the fl_hw_rep

Re: [RFC net-next 1/1] net: sched: fix hw filter offload in tc flower

2019-04-04 Thread John Hurley
On Wed, Apr 3, 2019 at 5:42 PM Vlad Buslov wrote: > > > On Wed 03 Apr 2019 at 15:37, John Hurley wrote: > > Recent refactoring of fl_change aims to use the classifier spinlock to > > avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer() > > function was moved to before the lock is

Re: [RFC net-next 1/1] net: sched: fix hw filter offload in tc flower

2019-04-03 Thread Vlad Buslov
On Wed 03 Apr 2019 at 15:37, John Hurley wrote: > Recent refactoring of fl_change aims to use the classifier spinlock to > avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer() > function was moved to before the lock is taken. This can create problems > for drivers if duplicate fi

[RFC net-next 1/1] net: sched: fix hw filter offload in tc flower

2019-04-03 Thread John Hurley
Recent refactoring of fl_change aims to use the classifier spinlock to avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer() function was moved to before the lock is taken. This can create problems for drivers if duplicate filters are created (commmon in ovs tc offload due to filters