Re: [RFC bpf-next 07/16] kallsyms: Use rb tree for kallsyms name search

2020-10-29 Thread Andrii Nakryiko
On Thu, Oct 29, 2020 at 2:31 AM Jiri Olsa wrote: > > On Wed, Oct 28, 2020 at 02:15:02PM -0700, Alexei Starovoitov wrote: > > On Wed, Oct 28, 2020 at 07:25:34PM +0100, Jiri Olsa wrote: > > > On Thu, Oct 22, 2020 at 10:21:29AM +0200, Jiri Olsa wrote: > > > > The kallsyms_expand_symbol function showe

Re: [RFC bpf-next 07/16] kallsyms: Use rb tree for kallsyms name search

2020-10-29 Thread Jiri Olsa
On Wed, Oct 28, 2020 at 03:40:46PM -0700, Andrii Nakryiko wrote: > On Wed, Oct 28, 2020 at 3:29 PM Jiri Olsa wrote: > > > > On Thu, Oct 22, 2020 at 10:21:29AM +0200, Jiri Olsa wrote: > > > The kallsyms_expand_symbol function showed in several bpf related > > > profiles, because it's doing linear s

Re: [RFC bpf-next 07/16] kallsyms: Use rb tree for kallsyms name search

2020-10-29 Thread Jiri Olsa
On Wed, Oct 28, 2020 at 02:15:02PM -0700, Alexei Starovoitov wrote: > On Wed, Oct 28, 2020 at 07:25:34PM +0100, Jiri Olsa wrote: > > On Thu, Oct 22, 2020 at 10:21:29AM +0200, Jiri Olsa wrote: > > > The kallsyms_expand_symbol function showed in several bpf related > > > profiles, because it's doing

Re: [RFC bpf-next 07/16] kallsyms: Use rb tree for kallsyms name search

2020-10-28 Thread Alexei Starovoitov
On Wed, Oct 28, 2020 at 07:25:34PM +0100, Jiri Olsa wrote: > On Thu, Oct 22, 2020 at 10:21:29AM +0200, Jiri Olsa wrote: > > The kallsyms_expand_symbol function showed in several bpf related > > profiles, because it's doing linear search. > > > > Before: > > > > Performance counter stats for './s

Re: [RFC bpf-next 07/16] kallsyms: Use rb tree for kallsyms name search

2020-10-28 Thread Andrii Nakryiko
On Wed, Oct 28, 2020 at 3:29 PM Jiri Olsa wrote: > > On Thu, Oct 22, 2020 at 10:21:29AM +0200, Jiri Olsa wrote: > > The kallsyms_expand_symbol function showed in several bpf related > > profiles, because it's doing linear search. > > > > Before: > > > > Performance counter stats for './src/bpftra

Re: [RFC bpf-next 07/16] kallsyms: Use rb tree for kallsyms name search

2020-10-28 Thread Jiri Olsa
On Thu, Oct 22, 2020 at 10:21:29AM +0200, Jiri Olsa wrote: > The kallsyms_expand_symbol function showed in several bpf related > profiles, because it's doing linear search. > > Before: > > Performance counter stats for './src/bpftrace -ve kfunc:__x64_sys_s* \ >{ printf("test\n"); } i:ms:10 {

[RFC bpf-next 07/16] kallsyms: Use rb tree for kallsyms name search

2020-10-22 Thread Jiri Olsa
The kallsyms_expand_symbol function showed in several bpf related profiles, because it's doing linear search. Before: Performance counter stats for './src/bpftrace -ve kfunc:__x64_sys_s* \ { printf("test\n"); } i:ms:10 { printf("exit\n"); exit();}' (5 runs): 2,535,458,767 cycles:k