Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-28 Thread Jason Gunthorpe
On Tue, Jul 28, 2020 at 02:01:16PM -0700, Jonathan Lemon wrote: > On Tue, Jul 28, 2020 at 03:19:04PM -0300, Jason Gunthorpe wrote: > > On Mon, Jul 27, 2020 at 06:48:12PM -0700, Jonathan Lemon wrote: > > > > > While the current GPU utilized is nvidia, there's nothing in the rest of > > > the patche

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-28 Thread Christoph Hellwig
On Tue, Jul 28, 2020 at 02:01:16PM -0700, Jonathan Lemon wrote: > For /this/ patch [21], this is quite true. I'm forced to use the nv_p2p > API if I want to use the hardware that I have. What's being overlooked > is that the host mem driver does not do this, nor would another GPU > if it used p2p

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-28 Thread Jonathan Lemon
On Tue, Jul 28, 2020 at 03:19:04PM -0300, Jason Gunthorpe wrote: > On Mon, Jul 27, 2020 at 06:48:12PM -0700, Jonathan Lemon wrote: > > > While the current GPU utilized is nvidia, there's nothing in the rest of > > the patches specific to Nvidia - an Intel or AMD GPU interface could be > > equally

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-28 Thread Chris Mason
On 28 Jul 2020, at 13:27, Christoph Hellwig wrote: On Tue, Jul 28, 2020 at 01:18:48PM -0400, Chris Mason wrote: come after in the future. Jonathan, I think we need to do a better job talking about patches that are just meant to enable possible users vs patches that we actually hope the upst

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-28 Thread Jason Gunthorpe
On Mon, Jul 27, 2020 at 06:48:12PM -0700, Jonathan Lemon wrote: > While the current GPU utilized is nvidia, there's nothing in the rest of > the patches specific to Nvidia - an Intel or AMD GPU interface could be > equally workable. I think that is very misleading. It looks like this patch, and

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-28 Thread Christoph Hellwig
On Tue, Jul 28, 2020 at 01:18:48PM -0400, Chris Mason wrote: > > come after in the future. > > Jonathan, I think we need to do a better job talking about patches that are > just meant to enable possible users vs patches that we actually hope the > upstream kernel to take. Obviously code that only

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-28 Thread Chris Mason
On 28 Jul 2020, at 12:31, Greg KH wrote: On Mon, Jul 27, 2020 at 03:44:44PM -0700, Jonathan Lemon wrote: From: Jonathan Lemon This provides the interface between the netgpu core module and the nvidia kernel driver. This should be built as an external module, pointing to the nvidia build. Fo

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-28 Thread Greg KH
On Mon, Jul 27, 2020 at 03:44:44PM -0700, Jonathan Lemon wrote: > From: Jonathan Lemon > > This provides the interface between the netgpu core module and the > nvidia kernel driver. This should be built as an external module, > pointing to the nvidia build. For example: > > export NV_PACKAGE_D

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-28 Thread Christoph Hellwig
On Tue, Jul 28, 2020 at 09:05:08AM -0700, Jonathan Lemon wrote: > On Tue, Jul 28, 2020 at 08:47:06AM +0200, Christoph Hellwig wrote: > > On Mon, Jul 27, 2020 at 06:48:12PM -0700, Jonathan Lemon wrote: > > > I'm aware that Nvidia code is maintained outside the tree, so this last > > > patch may bett

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-28 Thread Jonathan Lemon
On Tue, Jul 28, 2020 at 08:47:06AM +0200, Christoph Hellwig wrote: > On Mon, Jul 27, 2020 at 06:48:12PM -0700, Jonathan Lemon wrote: > > I'm aware that Nvidia code is maintained outside the tree, so this last > > patch may better placed there; I included it here so reviewers can see > > how things

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-27 Thread Christoph Hellwig
On Mon, Jul 27, 2020 at 06:48:12PM -0700, Jonathan Lemon wrote: > I'm aware that Nvidia code is maintained outside the tree, so this last > patch may better placed there; I included it here so reviewers can see > how things work. Sorry dude, but with statements like this you really disqualify your

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-27 Thread Jonathan Lemon
On Mon, Jul 27, 2020 at 08:24:25PM +0200, Christoph Hellwig wrote: > On Mon, Jul 27, 2020 at 10:00:03AM -0700, Jonathan Lemon wrote: > > On Mon, Jul 27, 2020 at 09:35:09AM +0200, Christoph Hellwig wrote: > > > Seriously? If you only even considered this is something reasonable > > > to do you shou

[RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-27 Thread Jonathan Lemon
From: Jonathan Lemon This provides the interface between the netgpu core module and the nvidia kernel driver. This should be built as an external module, pointing to the nvidia build. For example: export NV_PACKAGE_DIR=/w/nvidia/NVIDIA-Linux-x86_64-440.64 make -C ${kdir} M=`pwd` O=obj $* Sign

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-27 Thread Christoph Hellwig
On Mon, Jul 27, 2020 at 10:00:03AM -0700, Jonathan Lemon wrote: > On Mon, Jul 27, 2020 at 09:35:09AM +0200, Christoph Hellwig wrote: > > Seriously? If you only even considered this is something reasonable > > to do you should not be anywhere near Linux kernel development. > > > > Just go away! >

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-27 Thread Jonathan Lemon
On Mon, Jul 27, 2020 at 09:35:09AM +0200, Christoph Hellwig wrote: > Seriously? If you only even considered this is something reasonable > to do you should not be anywhere near Linux kernel development. > > Just go away! This isn't really a constructive comment. -- Jonathan

Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu

2020-07-27 Thread Christoph Hellwig
Seriously? If you only even considered this is something reasonable to do you should not be anywhere near Linux kernel development. Just go away!