Re: [RFC PATCH v0.2] net driver: mpc52xx fec

2007-10-02 Thread Robert Schwebel
On Tue, Oct 02, 2007 at 04:32:02PM +0200, Domen Puncer wrote: > The patch looks ok to me. Short update: even with the patch, the driver doesn't work on an rt-preempt enabled kernel, or at least not reliable. It survives normal traffic and ping -f, but dies when running nmap against the box, with a

Re: [RFC PATCH v0.2] net driver: mpc52xx fec

2007-10-02 Thread Domen Puncer
On 02/10/07 14:49 +0200, Sascha Hauer wrote: > > Hi Domen, Hi Sascha! > > On Sun, Sep 02, 2007 at 09:41:43AM +0200, Domen Puncer wrote: > + */ > > +static void fec_start(struct net_device *dev) > > +{ > > + struct fec_priv *priv = netdev_priv(dev); > > + struct mpc52xx_fec __iomem *fec =

Re: [RFC PATCH v0.2] net driver: mpc52xx fec

2007-10-02 Thread Sascha Hauer
Hi Domen, On Sun, Sep 02, 2007 at 09:41:43AM +0200, Domen Puncer wrote: + */ > +static void fec_start(struct net_device *dev) > +{ > + struct fec_priv *priv = netdev_priv(dev); > + struct mpc52xx_fec __iomem *fec = priv->fec; > + u32 rcntrl; > + u32 tcntrl; > + u32 tmp; > + >

Re: [RFC PATCH v0.2] net driver: mpc52xx fec

2007-09-17 Thread Sven Luther
On Sat, Sep 15, 2007 at 02:14:44PM +0200, Domen Puncer wrote: > Updated and split version at: > http://coderock.org/tmp/fec-v3rc1/ > > I'll repost to lists once I run-test them. When applying those patches, the build did die with : ERROR: "phy_mii_ioctl" [drivers/net/fec_mpc52xx/fec_mpc52xx.k

Re: [RFC PATCH v0.2] net driver: mpc52xx fec

2007-09-15 Thread Domen Puncer
On 03/09/07 09:57 -0600, Grant Likely wrote: > On 9/2/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > > Hi! > > > > new in this version: > > - fixed stuff that was commented on. > > - added 7-wire support (compile at least, if someone has the hardware, > > please test!) > > - ethtool support

Re: [RFC PATCH v0.2] net driver: mpc52xx fec

2007-09-03 Thread Grant Likely
On 9/3/07, Jon Smirl <[EMAIL PROTECTED]> wrote: > On 9/3/07, Grant Likely <[EMAIL PROTECTED]> wrote: > > On 9/2/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > > > Hi! > > > > > > new in this version: > > > - fixed stuff that was commented on. > > > - added 7-wire support (compile at least, if someon

Re: [RFC PATCH v0.2] net driver: mpc52xx fec

2007-09-03 Thread Jon Smirl
On 9/3/07, Grant Likely <[EMAIL PROTECTED]> wrote: > On 9/2/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > > Hi! > > > > new in this version: > > - fixed stuff that was commented on. > > - added 7-wire support (compile at least, if someone has the hardware, > > please test!) > > - ethtool su

Re: [RFC PATCH v0.2] net driver: mpc52xx fec

2007-09-03 Thread Grant Likely
On 9/2/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > Hi! > > new in this version: > - fixed stuff that was commented on. > - added 7-wire support (compile at least, if someone has the hardware, > please test!) > - ethtool support Thanks for this work Domen, comments below... This is a lar

[RFC PATCH v0.2] net driver: mpc52xx fec

2007-09-03 Thread Domen Puncer
Hi! new in this version: - fixed stuff that was commented on. - added 7-wire support (compile at least, if someone has the hardware, please test!) - ethtool support (this obsoletes Sylvain's patch that's floating around: 0008-drivers-net-Add-support-for-Freescale-MPC5200-SoC-i.patch) If