Re: [RFC PATCH v0.1] net driver: mpc52xx fec

2007-08-13 Thread Domen Puncer
On 10/08/07 10:02 -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 10, 2007 at 11:51:53AM +0200, Domen Puncer escreveu: > > +static u8 null_mac[6]; > > const OK. ... > > +static void fec_set_paddr(struct net_device *dev, u8 *mac) > > +{ > > + struct fec_priv *priv = netdev_priv(dev); > > +

Re: [RFC PATCH v0.1] net driver: mpc52xx fec

2007-08-10 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 10, 2007 at 11:51:53AM +0200, Domen Puncer escreveu: > Hi! > > Not for merge (yet)! But please do review. > > fec_mpc52xx driver (not in-tree, but floating around) isn't in very > good shape, so I tried to change that. > Diff against original is quite big (fec_phy.c is completely rewr

[RFC PATCH v0.1] net driver: mpc52xx fec

2007-08-10 Thread Domen Puncer
Hi! Not for merge (yet)! But please do review. fec_mpc52xx driver (not in-tree, but floating around) isn't in very good shape, so I tried to change that. Diff against original is quite big (fec_phy.c is completely rewritten) and confuzing, so I'm including whole drivers/net/fec_mpc52xx/ . I stil