Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean

2020-09-11 Thread Vladimir Oltean
On Fri, Sep 11, 2020 at 02:34:05PM -0700, Jesse Brandeburg wrote: > Here is a list of driver files with sparse warnings from C=1, maybe we > can encourage some others to help me fix them? I can take care of drivers/net/ethernet/freescale, thanks for the effort so far! I'll try to send a patch tomo

Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 14:34:05 -0700 Jesse Brandeburg wrote: > If I'm not mistaken *all* the warnings you had listed are from C=1 > (sparse) which would be best fixed with a second set of patches. This > set of patches only aimed to get rid of the W=1 (gcc warnings and kdoc > warnings from scripts/ke

Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean

2020-09-11 Thread Jesse Brandeburg
Jakub Kicinski wrote: > Yeah, maybe you need COMPILE_TEST? (full list of the warnings triggered > by the last patch at the end of the email) Ah, good idea, I checked and I have that set, however, I understand what's going on now. > > but I'd like to target the actual job you're running and use

Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean

2020-09-11 Thread Jakub Kicinski
On Fri, 11 Sep 2020 12:00:05 -0700 Jesse Brandeburg wrote: > > I feel slightly bad for saying this but I think your config did not > > include all the drivers, 'cause I'm still getting some warnings after > > patch 11. Regardless this is impressive effort, thanks! > > No worries! I want to get i

Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean

2020-09-11 Thread Jesse Brandeburg
Jakub Kicinski wrote: > On Thu, 10 Sep 2020 18:23:26 -0700 Jesse Brandeburg wrote: > > Some of these patches are already sent to Intel Wired Lan, but the rest > > of the series titled drivers/net/ethernet affects other drivers, not > > just Intel, but they depend on the first five. > > Great stuf

Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean

2020-09-11 Thread Jakub Kicinski
On Thu, 10 Sep 2020 18:23:26 -0700 Jesse Brandeburg wrote: > This series is a placeholder to show I've about finished this work. > > After applying the patches below, the drivers/net/ethernet > directory can be built as modules with W=1 with no warnings. > > This series removes 1,283 warnings and

[RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean

2020-09-10 Thread Jesse Brandeburg
This series is a placeholder to show I've about finished this work. After applying the patches below, the drivers/net/ethernet directory can be built as modules with W=1 with no warnings. This series removes 1,283 warnings and hopefully allows the ethernet directory to move forward from here with