Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

2016-04-21 Thread Edward Cree
On 19/04/16 14:37, Edward Cree wrote: > Also involved adding a way to run a netfilter hook over a list of packets. Turns out, this breaks the build if netfilter is *disabled*, because I forgot to add a stub in that case. Next version of patch (if there is one) will have the following under #ifndef

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

2016-04-19 Thread Tom Herbert
On Tue, Apr 19, 2016 at 10:12 AM, Edward Cree wrote: > On 19/04/16 16:46, Tom Herbert wrote: >> On Tue, Apr 19, 2016 at 7:50 AM, Eric Dumazet wrote: >>> We have hard time to deal with latencies already, and maintaining some >>> sanity in the stack(s) >> Right, this is significant complexity for a

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

2016-04-19 Thread Eric Dumazet
On Tue, 2016-04-19 at 17:50 +0100, Edward Cree wrote: > On 19/04/16 15:50, Eric Dumazet wrote: > > The main problem in UDP stack today is having to lock the socket because > > of the dumb forward allocation problem. > I'm not quite sure what you're referring to here, care to educate me? This was

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

2016-04-19 Thread Eric Dumazet
On Tue, 2016-04-19 at 18:12 +0100, Edward Cree wrote: > I think if we pushed bundled RX all the way up to the TCP layer, it might > potentially also be faster than GRO, because it avoids the work of > coalescing superframes; plus going through the GRO callbacks for each > packet could end up blowi

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

2016-04-19 Thread Edward Cree
On 19/04/16 16:46, Tom Herbert wrote: > On Tue, Apr 19, 2016 at 7:50 AM, Eric Dumazet wrote: >> We have hard time to deal with latencies already, and maintaining some >> sanity in the stack(s) > Right, this is significant complexity for a fairly narrow use case. Why do you say the use case is narr

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

2016-04-19 Thread Edward Cree
On 19/04/16 15:50, Eric Dumazet wrote: > The main problem in UDP stack today is having to lock the socket because > of the dumb forward allocation problem. I'm not quite sure what you're referring to here, care to educate me? > Are you really going to provide > a list of skbs up to _one_ UDP socke

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

2016-04-19 Thread Eric Dumazet
On Tue, 2016-04-19 at 08:46 -0700, Tom Herbert wrote: > Right, this is significant complexity for a fairly narrow use case. > One alternative might be to move early type demux like functionality > to the GRO layer. There's a lot of work done by GRO to parse and > identify packets of the same flow,

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

2016-04-19 Thread Tom Herbert
On Tue, Apr 19, 2016 at 7:50 AM, Eric Dumazet wrote: > On Tue, 2016-04-19 at 14:37 +0100, Edward Cree wrote: >> Also involved adding a way to run a netfilter hook over a list of packets. >> Rather than attempting to make netfilter know about lists (which would be >> horrendous) we just let it call

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

2016-04-19 Thread Eric Dumazet
On Tue, 2016-04-19 at 14:37 +0100, Edward Cree wrote: > Also involved adding a way to run a netfilter hook over a list of packets. > Rather than attempting to make netfilter know about lists (which would be > horrendous) we just let it call the regular okfn (in this case > ip_rcv_finish()) for any

[RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

2016-04-19 Thread Edward Cree
Also involved adding a way to run a netfilter hook over a list of packets. Rather than attempting to make netfilter know about lists (which would be horrendous) we just let it call the regular okfn (in this case ip_rcv_finish()) for any packets it steals, and have it give us back a list of packets