Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-17 Thread Jacob Keller
On 7/16/2020 3:18 PM, Jakub Kicinski wrote: > On Thu, 16 Jul 2020 14:52:15 -0700 Jacob Keller wrote: >> On 7/16/2020 2:42 PM, Jakub Kicinski wrote: >>> Sorry but I'm still not 100% sure of what the use for this option is >>> beyond an OEM. Is it possible to reset the VPD, board serial, MAC >>> a

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-16 Thread Jakub Kicinski
On Thu, 16 Jul 2020 14:52:15 -0700 Jacob Keller wrote: > On 7/16/2020 2:42 PM, Jakub Kicinski wrote: > > On Thu, 16 Jul 2020 14:29:40 -0700 Jacob Keller wrote: > >> On 7/15/2020 5:21 PM, Jacob Keller wrote: > >>> Ok, that seems reasonable. Ofcourse we'll need to find something generic > >>> eno

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-16 Thread Jacob Keller
On 7/16/2020 2:42 PM, Jakub Kicinski wrote: > On Thu, 16 Jul 2020 14:29:40 -0700 Jacob Keller wrote: >> On 7/15/2020 5:21 PM, Jacob Keller wrote: >>> Ok, that seems reasonable. Ofcourse we'll need to find something generic >>> enough that it can be re-used and isn't driver specific. >> >> Hi Jak

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-16 Thread Jakub Kicinski
On Thu, 16 Jul 2020 14:29:40 -0700 Jacob Keller wrote: > On 7/15/2020 5:21 PM, Jacob Keller wrote: > > Ok, that seems reasonable. Ofcourse we'll need to find something generic > > enough that it can be re-used and isn't driver specific. > > Hi Jakub, > > I think I have something that will be more

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-16 Thread Jacob Keller
On 7/15/2020 5:21 PM, Jacob Keller wrote: > > > On 7/15/2020 4:23 PM, Jakub Kicinski wrote: >> On Wed, 15 Jul 2020 14:41:04 -0700 Jacob Keller wrote: >>> To summarize this discussion, the next spin will have the following changes: >>> >>> 1) remove all parameters except for the preservation_le

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-15 Thread Jacob Keller
On 7/15/2020 4:23 PM, Jakub Kicinski wrote: > On Wed, 15 Jul 2020 14:41:04 -0700 Jacob Keller wrote: >> To summarize this discussion, the next spin will have the following changes: >> >> 1) remove all parameters except for the preservation_level. Both >> ignore_pending_flash_update and allow_dow

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-15 Thread Jakub Kicinski
On Wed, 15 Jul 2020 14:41:04 -0700 Jacob Keller wrote: > To summarize this discussion, the next spin will have the following changes: > > 1) remove all parameters except for the preservation_level. Both > ignore_pending_flash_update and allow_downgrade_on_flash_update will be > removed and change

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-15 Thread Jacob Keller
On 7/10/2020 1:32 PM, Jacob Keller wrote: > > > On 7/10/2020 1:25 PM, Jakub Kicinski wrote: >> On Fri, 10 Jul 2020 10:32:24 -0700 Jacob Keller wrote: >>> On 7/9/2020 5:19 PM, Jakub Kicinski wrote: On Thu, 9 Jul 2020 14:26:52 -0700 Jacob Keller wrote: > The flash update for the ice har

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-10 Thread Jacob Keller
On 7/10/2020 1:25 PM, Jakub Kicinski wrote: > On Fri, 10 Jul 2020 10:32:24 -0700 Jacob Keller wrote: >> On 7/9/2020 5:19 PM, Jakub Kicinski wrote: >>> On Thu, 9 Jul 2020 14:26:52 -0700 Jacob Keller wrote: The flash update for the ice hardware currently supports a single fixed config

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-10 Thread Jakub Kicinski
On Fri, 10 Jul 2020 10:32:24 -0700 Jacob Keller wrote: > On 7/9/2020 5:19 PM, Jakub Kicinski wrote: > > On Thu, 9 Jul 2020 14:26:52 -0700 Jacob Keller wrote: > >> The flash update for the ice hardware currently supports a single fixed > >> configuration: > >> > >> * Firmware is always asked to p

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-10 Thread Jacob Keller
On 7/9/2020 5:19 PM, Jakub Kicinski wrote: > On Thu, 9 Jul 2020 14:26:52 -0700 Jacob Keller wrote: >> The flash update for the ice hardware currently supports a single fixed >> configuration: >> >> * Firmware is always asked to preserve all changeable fields >> * The driver never allows downgra

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-09 Thread Vasundhara Volam
On Fri, Jul 10, 2020 at 5:56 AM Jakub Kicinski wrote: > > On Thu, 9 Jul 2020 14:26:52 -0700 Jacob Keller wrote: > > The flash update for the ice hardware currently supports a single fixed > > configuration: > > > > * Firmware is always asked to preserve all changeable fields > > * The driver neve

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-09 Thread Jakub Kicinski
On Thu, 9 Jul 2020 14:26:52 -0700 Jacob Keller wrote: > The flash update for the ice hardware currently supports a single fixed > configuration: > > * Firmware is always asked to preserve all changeable fields > * The driver never allows downgrades > * The driver will not allow canceling a previo

[RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-09 Thread Jacob Keller
The flash update for the ice hardware currently supports a single fixed configuration: * Firmware is always asked to preserve all changeable fields * The driver never allows downgrades * The driver will not allow canceling a previous update that never completed (for example because an EMP reset