Re: [RFC PATCH net-next 2/3] net: hsr: add DSA offloading support

2021-01-26 Thread George McCollister
On Sun, Jan 24, 2021 at 2:43 AM Vladimir Oltean wrote: > [snip] > > I would like to give HSR a spin to get a better idea of what you're doing, but > it's kinda hard when this happens out of the box, with none of your changes > already: > > [ 1385.000453] hsr0: hw csum failure > [ 1385.004105] skb

Re: [RFC PATCH net-next 2/3] net: hsr: add DSA offloading support

2021-01-25 Thread George McCollister
On Sun, Jan 24, 2021 at 11:29 AM Vladimir Oltean wrote: > > On Fri, Jan 22, 2021 at 09:59:47AM -0600, George McCollister wrote: > > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > > index f2fb433f3828..fc7e3ff11c5c 100644 > > --- a/net/dsa/slave.c > > +++ b/net/dsa/slave.c > > @@ -1924,6 +1924,19

Re: [RFC PATCH net-next 2/3] net: hsr: add DSA offloading support

2021-01-24 Thread Vladimir Oltean
On Fri, Jan 22, 2021 at 09:59:47AM -0600, George McCollister wrote: > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > index f2fb433f3828..fc7e3ff11c5c 100644 > --- a/net/dsa/slave.c > +++ b/net/dsa/slave.c > @@ -1924,6 +1924,19 @@ static int dsa_slave_changeupper(struct net_device > *dev, >

Re: [RFC PATCH net-next 2/3] net: hsr: add DSA offloading support

2021-01-24 Thread Vladimir Oltean
Hi George, On Fri, Jan 22, 2021 at 12:48:11PM -0600, Nishanth Menon wrote: > On 10:00-20210122, Florian Fainelli wrote: > [...] > > > >> + > > >> +This should be set for devices which duplicate outgoing HSR (highspeed > > >> ring) > > >> +frames in hardware. > > > > > > Do you think we can start

Re: [RFC PATCH net-next 2/3] net: hsr: add DSA offloading support

2021-01-22 Thread George McCollister
On Fri, Jan 22, 2021 at 11:56 AM Florian Fainelli wrote: > > > > On 1/22/2021 7:59 AM, George McCollister wrote: > > Add support for offloading of HSR/PRP (IEC 62439-3) tag insertion > > tag removal, duplicate generation and forwarding on DSA switches. > > > > Use a new netdev_priv_flag IFF_HSR to

Re: [RFC PATCH net-next 2/3] net: hsr: add DSA offloading support

2021-01-22 Thread Nishanth Menon
On 10:00-20210122, Florian Fainelli wrote: [...] > >> + > >> +This should be set for devices which duplicate outgoing HSR (highspeed > >> ring) > >> +frames in hardware. > > > > Do you think we can start with a hsr-hw-offload feature and create new > > bits to described how challenged a device m

Re: [RFC PATCH net-next 2/3] net: hsr: add DSA offloading support

2021-01-22 Thread Florian Fainelli
On 1/22/2021 9:56 AM, Florian Fainelli wrote: > > > On 1/22/2021 7:59 AM, George McCollister wrote: >> Add support for offloading of HSR/PRP (IEC 62439-3) tag insertion >> tag removal, duplicate generation and forwarding on DSA switches. >> >> Use a new netdev_priv_flag IFF_HSR to indicate tha

Re: [RFC PATCH net-next 2/3] net: hsr: add DSA offloading support

2021-01-22 Thread Florian Fainelli
On 1/22/2021 7:59 AM, George McCollister wrote: > Add support for offloading of HSR/PRP (IEC 62439-3) tag insertion > tag removal, duplicate generation and forwarding on DSA switches. > > Use a new netdev_priv_flag IFF_HSR to indicate that a device is an HSR > device so DSA can tell them apart

[RFC PATCH net-next 2/3] net: hsr: add DSA offloading support

2021-01-22 Thread George McCollister
Add support for offloading of HSR/PRP (IEC 62439-3) tag insertion tag removal, duplicate generation and forwarding on DSA switches. Use a new netdev_priv_flag IFF_HSR to indicate that a device is an HSR device so DSA can tell them apart from other devices in dsa_slave_changeupper. Add DSA_NOTIFIE