Re: [RFC PATCH net-next 10/12] drop_monitor: Add packet alert mode

2019-07-24 Thread Ido Schimmel
On Wed, Jul 24, 2019 at 02:53:41PM +0200, Jiri Pirko wrote: > Mon, Jul 22, 2019 at 08:31:32PM CEST, ido...@idosch.org wrote: > >+static const struct net_dm_alert_ops *net_dm_alert_ops_arr[] = { > >+[NET_DM_ALERT_MODE_SUMMARY] = &net_dm_alert_summary_ops, > >+[NET_DM_ALERT_MODE_PACKET]

Re: [RFC PATCH net-next 10/12] drop_monitor: Add packet alert mode

2019-07-24 Thread Jiri Pirko
Mon, Jul 22, 2019 at 08:31:32PM CEST, ido...@idosch.org wrote: >From: Ido Schimmel > >So far drop monitor supported only one alert mode in which a summary of >locations in which packets were recently dropped was sent to user space. > >This alert mode is sufficient in order to understand that packe

Re: [RFC PATCH net-next 10/12] drop_monitor: Add packet alert mode

2019-07-24 Thread Ido Schimmel
On Tue, Jul 23, 2019 at 11:14:31AM -0400, Neil Horman wrote: > On Tue, Jul 23, 2019 at 05:16:25PM +0300, Ido Schimmel wrote: > > On Tue, Jul 23, 2019 at 08:43:40AM -0400, Neil Horman wrote: > > > On Mon, Jul 22, 2019 at 09:31:32PM +0300, Ido Schimmel wrote: > > > > +static void net_dm_packet_work(s

Re: [RFC PATCH net-next 10/12] drop_monitor: Add packet alert mode

2019-07-23 Thread Neil Horman
On Tue, Jul 23, 2019 at 05:16:25PM +0300, Ido Schimmel wrote: > On Tue, Jul 23, 2019 at 08:43:40AM -0400, Neil Horman wrote: > > On Mon, Jul 22, 2019 at 09:31:32PM +0300, Ido Schimmel wrote: > > > +static void net_dm_packet_work(struct work_struct *work) > > > +{ > > > + struct per_cpu_dm_data *dat

Re: [RFC PATCH net-next 10/12] drop_monitor: Add packet alert mode

2019-07-23 Thread Ido Schimmel
On Tue, Jul 23, 2019 at 08:43:40AM -0400, Neil Horman wrote: > On Mon, Jul 22, 2019 at 09:31:32PM +0300, Ido Schimmel wrote: > > +static void net_dm_packet_work(struct work_struct *work) > > +{ > > + struct per_cpu_dm_data *data; > > + struct sk_buff_head list; > > + struct sk_buff *skb; > >

Re: [RFC PATCH net-next 10/12] drop_monitor: Add packet alert mode

2019-07-23 Thread Neil Horman
On Mon, Jul 22, 2019 at 09:31:32PM +0300, Ido Schimmel wrote: > From: Ido Schimmel > > So far drop monitor supported only one alert mode in which a summary of > locations in which packets were recently dropped was sent to user space. > > This alert mode is sufficient in order to understand that

[RFC PATCH net-next 10/12] drop_monitor: Add packet alert mode

2019-07-22 Thread Ido Schimmel
From: Ido Schimmel So far drop monitor supported only one alert mode in which a summary of locations in which packets were recently dropped was sent to user space. This alert mode is sufficient in order to understand that packets were dropped, but lacks information to perform a more detailed ana