Re: [RFC PATCH net-next 1/1] Introduce skbmod action

2016-07-17 Thread Cong Wang
On Sat, Jul 16, 2016 at 7:28 AM, Jamal Hadi Salim wrote: > On 16-07-12 01:10 PM, Cong Wang wrote: >> >> On Mon, Jul 11, 2016 at 5:12 AM, Jamal Hadi Salim >> wrote: >>> >>> From: Jamal Hadi Salim >>> >>> This action is intended to be an upgrade from a usability perspective >>> from pedit. Compare

Re: [RFC PATCH net-next 1/1] Introduce skbmod action

2016-07-16 Thread Jamal Hadi Salim
On 16-07-12 01:10 PM, Cong Wang wrote: On Mon, Jul 11, 2016 at 5:12 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim This action is intended to be an upgrade from a usability perspective from pedit. Compare this: Definitely agree we need a more user-friendly interface. pedit is a good

Re: [RFC PATCH net-next 1/1] Introduce skbmod action

2016-07-12 Thread Cong Wang
On Mon, Jul 11, 2016 at 5:12 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > This action is intended to be an upgrade from a usability perspective > from pedit. Compare this: > Definitely agree we need a more user-friendly interface. > > pedit is a good starting point - but once you st

[RFC PATCH net-next 1/1] Introduce skbmod action

2016-07-11 Thread Jamal Hadi Salim
From: Jamal Hadi Salim This action is intended to be an upgrade from a usability perspective from pedit. Compare this: sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \ u32 match ip protocol 1 0xff flowid 1:2 \ action pedit munge offset -14 u8 set 0x02 \ munge offset -13 u8 set