Alexander Duyck wrote:
On 10/30/2015 09:25 AM, Jarod Wilson wrote:
...
Rather than outright dropping the second bit though, I was thinking
maybe just drop a note in dmesg along the lines of "hey, you shut off
LRO, it is still enabled on upper dev foo", to placate end-users.
I would rather not
On 10/30/2015 09:35 AM, Jarod Wilson wrote:
Alexander Duyck wrote:
On 10/23/2015 08:40 PM, Jarod Wilson wrote:
There are some netdev features that make little sense to toggle on and
off in a stacked device setup on only one device in the stack. The prime
example is a bonded connection, where it
On 10/30/2015 09:25 AM, Jarod Wilson wrote:
Michal Kubecek wrote:
On Fri, Oct 23, 2015 at 10:51:09PM -0700, Alexander Duyck wrote:
On 10/23/2015 08:40 PM, Jarod Wilson wrote:
+static netdev_features_t netdev_sync_upper_features(struct
net_device *lower,
+struct net_device *upper, netdev_fe
Alexander Duyck wrote:
On 10/23/2015 08:40 PM, Jarod Wilson wrote:
There are some netdev features that make little sense to toggle on and
off in a stacked device setup on only one device in the stack. The prime
example is a bonded connection, where it really doesn't make sense to
disable LRO on
Michal Kubecek wrote:
On Fri, Oct 23, 2015 at 10:51:09PM -0700, Alexander Duyck wrote:
On 10/23/2015 08:40 PM, Jarod Wilson wrote:
+static netdev_features_t netdev_sync_upper_features(struct net_device *lower,
+ struct net_device *upper, netdev_features_t features)
+{
+ netdev_featu
On Fri, Oct 23, 2015 at 10:51:09PM -0700, Alexander Duyck wrote:
> On 10/23/2015 08:40 PM, Jarod Wilson wrote:
> >
> >+static netdev_features_t netdev_sync_upper_features(struct net_device
> >*lower,
> >+struct net_device *upper, netdev_features_t features)
> >+{
> >+netdev_features_t want
On 10/23/2015 08:40 PM, Jarod Wilson wrote:
There are some netdev features that make little sense to toggle on and
off in a stacked device setup on only one device in the stack. The prime
example is a bonded connection, where it really doesn't make sense to
disable LRO on the master, but not on a
On Fri, Oct 23, 2015 at 11:40 PM, Jarod Wilson wrote:
> There are some netdev features that make little sense to toggle on and
> off in a stacked device setup on only one device in the stack. The prime
> example is a bonded connection, where it really doesn't make sense to
> disable LRO on the mas
There are some netdev features that make little sense to toggle on and
off in a stacked device setup on only one device in the stack. The prime
example is a bonded connection, where it really doesn't make sense to
disable LRO on the master, but not on any of the slaves, nor does it
really make sens
