Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-21 Thread Jakub Kicinski
On Wed, 21 Aug 2019 17:49:33 +0900, Toshiaki Makita wrote: > > Having an implementation nor support a feature of another implementation > > and degrade gracefully to the slower one is not necessarily breakage. > > We need to make a concious decision here, hence the clarifying question. > > As I

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-21 Thread Toshiaki Makita
On 19/08/20 (火) 3:15:46, Jakub Kicinski wrote: I'm on vacation and replying slowly. Sorry for any inconvenience. On Sat, 17 Aug 2019 23:01:59 +0900, Toshiaki Makita wrote: On 19/08/17 (土) 3:52:24, Jakub Kicinski wrote: On Fri, 16 Aug 2019 10:28:10 +0900, Toshiaki Makita wrote: On 2019/08/16

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-19 Thread Jakub Kicinski
On Sat, 17 Aug 2019 23:01:59 +0900, Toshiaki Makita wrote: > On 19/08/17 (土) 3:52:24, Jakub Kicinski wrote: > > On Fri, 16 Aug 2019 10:28:10 +0900, Toshiaki Makita wrote: > >> On 2019/08/16 4:22, Jakub Kicinski wrote: > >>> There's a certain allure in bringing the in-kernel BPF translation > >>

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-17 Thread Toshiaki Makita
On 19/08/17 (土) 0:35:50, Stanislav Fomichev wrote: On 08/16, Toshiaki Makita wrote: On 2019/08/16 0:21, Stanislav Fomichev wrote: On 08/15, Toshiaki Makita wrote: On 2019/08/15 2:07, Stanislav Fomichev wrote: On 08/13, Toshiaki Makita wrote: * Implementation xdp_flow makes use of UMH to loa

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-17 Thread Toshiaki Makita
On 19/08/17 (土) 3:52:24, Jakub Kicinski wrote: On Fri, 16 Aug 2019 10:28:10 +0900, Toshiaki Makita wrote: On 2019/08/16 4:22, Jakub Kicinski wrote: There's a certain allure in bringing the in-kernel BPF translation infrastructure forward. OTOH from system architecture perspective IMHO it does s

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-16 Thread Jakub Kicinski
On Fri, 16 Aug 2019 10:28:10 +0900, Toshiaki Makita wrote: > On 2019/08/16 4:22, Jakub Kicinski wrote: > > There's a certain allure in bringing the in-kernel BPF translation > > infrastructure forward. OTOH from system architecture perspective IMHO > > it does seem like a task best handed in user s

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-16 Thread Stanislav Fomichev
On 08/16, Stanislav Fomichev wrote: > On 08/15, Jakub Kicinski wrote: > > On Thu, 15 Aug 2019 08:21:00 -0700, Stanislav Fomichev wrote: > > > On 08/15, Toshiaki Makita wrote: > > > > On 2019/08/15 2:07, Stanislav Fomichev wrote: > > > > > On 08/13, Toshiaki Makita wrote: > > > > > > * Implement

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-16 Thread Stanislav Fomichev
On 08/15, Jakub Kicinski wrote: > On Thu, 15 Aug 2019 08:21:00 -0700, Stanislav Fomichev wrote: > > On 08/15, Toshiaki Makita wrote: > > > On 2019/08/15 2:07, Stanislav Fomichev wrote: > > > > On 08/13, Toshiaki Makita wrote: > > > > > * Implementation > > > > > > > > > > xdp_flow makes use of

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-16 Thread Stanislav Fomichev
On 08/16, Toshiaki Makita wrote: > On 2019/08/16 0:21, Stanislav Fomichev wrote: > > On 08/15, Toshiaki Makita wrote: > > > On 2019/08/15 2:07, Stanislav Fomichev wrote: > > > > On 08/13, Toshiaki Makita wrote: > > > > > * Implementation > > > > > > > > > > xdp_flow makes use of UMH to load an eBP

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-15 Thread Toshiaki Makita
On 2019/08/16 0:46, William Tu wrote: On Tue, Aug 13, 2019 at 5:07 AM Toshiaki Makita wrote: This is a rough PoC for an idea to offload TC flower to XDP. * Motivation The purpose is to speed up software TC flower by using XDP. I chose TC flower because my current interest is in OVS. OVS us

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-15 Thread Toshiaki Makita
On 2019/08/16 4:22, Jakub Kicinski wrote: On Thu, 15 Aug 2019 08:21:00 -0700, Stanislav Fomichev wrote: On 08/15, Toshiaki Makita wrote: On 2019/08/15 2:07, Stanislav Fomichev wrote: On 08/13, Toshiaki Makita wrote: * Implementation xdp_flow makes use of UMH to load an eBPF program for XDP,

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-15 Thread Toshiaki Makita
On 2019/08/16 0:21, Stanislav Fomichev wrote: On 08/15, Toshiaki Makita wrote: On 2019/08/15 2:07, Stanislav Fomichev wrote: On 08/13, Toshiaki Makita wrote: * Implementation xdp_flow makes use of UMH to load an eBPF program for XDP, similar to bpfilter. The difference is that xdp_flow does n

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-15 Thread Jakub Kicinski
On Thu, 15 Aug 2019 08:21:00 -0700, Stanislav Fomichev wrote: > On 08/15, Toshiaki Makita wrote: > > On 2019/08/15 2:07, Stanislav Fomichev wrote: > > > On 08/13, Toshiaki Makita wrote: > > > > * Implementation > > > > > > > > xdp_flow makes use of UMH to load an eBPF program for XDP, similar

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-15 Thread William Tu
On Tue, Aug 13, 2019 at 5:07 AM Toshiaki Makita wrote: > > This is a rough PoC for an idea to offload TC flower to XDP. > > > * Motivation > > The purpose is to speed up software TC flower by using XDP. > > I chose TC flower because my current interest is in OVS. OVS uses TC to > offload flow tabl

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-15 Thread Stanislav Fomichev
On 08/15, Toshiaki Makita wrote: > On 2019/08/15 2:07, Stanislav Fomichev wrote: > > On 08/13, Toshiaki Makita wrote: > > > * Implementation > > > > > > xdp_flow makes use of UMH to load an eBPF program for XDP, similar to > > > bpfilter. The difference is that xdp_flow does not generate the eBPF

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-15 Thread Toshiaki Makita
On 2019/08/14 16:33, Toshiaki Makita wrote:    bpf, hashtab: Compare keys in long 3Mpps vs 4Mpps just from this patch ? or combined with i40 prefech patch ? Combined.   drivers/net/ethernet/intel/i40e/i40e_txrx.c  |    1 + Could you share "perf report" for just hash tab optimization and f

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-15 Thread Toshiaki Makita
On 2019/08/15 2:07, Stanislav Fomichev wrote: On 08/13, Toshiaki Makita wrote: * Implementation xdp_flow makes use of UMH to load an eBPF program for XDP, similar to bpfilter. The difference is that xdp_flow does not generate the eBPF program dynamically but a prebuilt program is embedded in UM

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-14 Thread Stanislav Fomichev
On 08/13, Toshiaki Makita wrote: > * Implementation > > xdp_flow makes use of UMH to load an eBPF program for XDP, similar to > bpfilter. The difference is that xdp_flow does not generate the eBPF > program dynamically but a prebuilt program is embedded in UMH. This is > mainly because flow insert

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-14 Thread Toshiaki Makita
Hi Alexei, thank you for taking a look! On 2019/08/14 10:44, Alexei Starovoitov wrote: On Tue, Aug 13, 2019 at 09:05:44PM +0900, Toshiaki Makita wrote: This is a rough PoC for an idea to offload TC flower to XDP. ... xdp_flow TCovs kmod 4.0 Mpps 1.

Re: [RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-13 Thread Alexei Starovoitov
On Tue, Aug 13, 2019 at 09:05:44PM +0900, Toshiaki Makita wrote: > This is a rough PoC for an idea to offload TC flower to XDP. ... > xdp_flow TCovs kmod > > 4.0 Mpps 1.1 Mpps 1.1 Mpps Is xdp_flow limited to 4 Mpps due to veth or something else? > > So

[RFC PATCH bpf-next 00/14] xdp_flow: Flow offload to XDP

2019-08-13 Thread Toshiaki Makita
This is a rough PoC for an idea to offload TC flower to XDP. * Motivation The purpose is to speed up software TC flower by using XDP. I chose TC flower because my current interest is in OVS. OVS uses TC to offload flow tables to hardware, so if TC can offload flows to XDP, OVS also can be offlo