Re: [RFC PATCH bpf-next] bpf: add bpf_get_skb_hash helper function

2020-08-12 Thread David Ahern
On 8/11/20 3:55 PM, Ramamurthy, Harshitha wrote: > is a pre-cursor to potentially calling the in-kernel flow dissector from > a helper function. > That is going to be a challenge to do in a way that does not impact the kernel's ability to change as needed, and I suspect it will be much slower tha

Re: [RFC PATCH bpf-next] bpf: add bpf_get_skb_hash helper function

2020-08-12 Thread Ramamurthy, Harshitha
On Mon, 2020-08-10 at 13:02 -0600, David Ahern wrote: > On 8/10/20 12:28 PM, Harshitha Ramamurthy wrote: > > This patch adds a helper function called bpf_get_skb_hash to > > calculate > > the skb hash for a packet at the XDP layer. In the helper function, > > Why? i.e., expected use case? > > Pul

Recall: [RFC PATCH bpf-next] bpf: add bpf_get_skb_hash helper function

2020-08-11 Thread Ramamurthy, Harshitha
Ramamurthy, Harshitha would like to recall the message, "[RFC PATCH bpf-next] bpf: add bpf_get_skb_hash helper function".

Re: [RFC PATCH bpf-next] bpf: add bpf_get_skb_hash helper function

2020-08-10 Thread David Ahern
On 8/10/20 12:28 PM, Harshitha Ramamurthy wrote: > This patch adds a helper function called bpf_get_skb_hash to calculate > the skb hash for a packet at the XDP layer. In the helper function, Why? i.e., expected use case? Pulling this from hardware when possible is better. e.g., Saeed's hardware

[RFC PATCH bpf-next] bpf: add bpf_get_skb_hash helper function

2020-08-10 Thread Harshitha Ramamurthy
This patch adds a helper function called bpf_get_skb_hash to calculate the skb hash for a packet at the XDP layer. In the helper function, a local skb is allocated and we populate the fields needed in the skb before calling skb_get_hash. To avoid memory allocations for each packet, we allocate an s