Re: [RFC PATCH V4] pci: virtio_pci: Add SR-IOV support for virtio_pci devices

2018-02-26 Thread Alexander Duyck
On Mon, Feb 26, 2018 at 2:38 PM, Michael S. Tsirkin wrote: > On Mon, Feb 26, 2018 at 10:05:31AM -0800, Alexander Duyck wrote: >> On Mon, Feb 26, 2018 at 9:48 AM, Rustad, Mark D >> wrote: >> > Alex, >> > >> >> On Feb 26, 2018, at 7:26 AM, Alexander Duyck >> >> wrote: >> >> >> >> Mark, >> >> >>

Re: [RFC PATCH V4] pci: virtio_pci: Add SR-IOV support for virtio_pci devices

2018-02-26 Thread Michael S. Tsirkin
On Mon, Feb 26, 2018 at 02:38:01PM -0800, Alexander Duyck wrote: > On Mon, Feb 26, 2018 at 2:32 PM, Michael S. Tsirkin wrote: > > On Mon, Feb 26, 2018 at 07:26:14AM -0800, Alexander Duyck wrote: > >> On Sun, Feb 25, 2018 at 8:48 PM, Mark Rustad > >> wrote: > >> > Hardware-realized virtio_pci dev

Re: [RFC PATCH V4] pci: virtio_pci: Add SR-IOV support for virtio_pci devices

2018-02-26 Thread Michael S. Tsirkin
On Mon, Feb 26, 2018 at 10:05:31AM -0800, Alexander Duyck wrote: > On Mon, Feb 26, 2018 at 9:48 AM, Rustad, Mark D > wrote: > > Alex, > > > >> On Feb 26, 2018, at 7:26 AM, Alexander Duyck > >> wrote: > >> > >> Mark, > >> > >> In the future please don't put my "Reviewed-by" on a patch that I > >

Re: [RFC PATCH V4] pci: virtio_pci: Add SR-IOV support for virtio_pci devices

2018-02-26 Thread Alexander Duyck
On Mon, Feb 26, 2018 at 2:32 PM, Michael S. Tsirkin wrote: > On Mon, Feb 26, 2018 at 07:26:14AM -0800, Alexander Duyck wrote: >> On Sun, Feb 25, 2018 at 8:48 PM, Mark Rustad wrote: >> > Hardware-realized virtio_pci devices can implement SR-IOV, so this >> > patch enables its use. The device in qu

Re: [RFC PATCH V4] pci: virtio_pci: Add SR-IOV support for virtio_pci devices

2018-02-26 Thread Michael S. Tsirkin
On Mon, Feb 26, 2018 at 07:26:14AM -0800, Alexander Duyck wrote: > On Sun, Feb 25, 2018 at 8:48 PM, Mark Rustad wrote: > > Hardware-realized virtio_pci devices can implement SR-IOV, so this > > patch enables its use. The device in question is an upcoming Intel > > NIC that implements both a virtio

Re: [RFC PATCH V4] pci: virtio_pci: Add SR-IOV support for virtio_pci devices

2018-02-26 Thread Alexander Duyck
On Mon, Feb 26, 2018 at 9:48 AM, Rustad, Mark D wrote: > Alex, > >> On Feb 26, 2018, at 7:26 AM, Alexander Duyck >> wrote: >> >> Mark, >> >> In the future please don't put my "Reviewed-by" on a patch that I >> haven't reviewed. I believe I reviewed one of the earlier patches, but >> I hadn't rev

Re: [RFC PATCH V4] pci: virtio_pci: Add SR-IOV support for virtio_pci devices

2018-02-26 Thread Rustad, Mark D
Alex, > On Feb 26, 2018, at 7:26 AM, Alexander Duyck > wrote: > > Mark, > > In the future please don't put my "Reviewed-by" on a patch that I > haven't reviewed. I believe I reviewed one of the earlier patches, but > I hadn't reviewed this version. I'm very sorry. I completely spaced doing so

Re: [RFC PATCH V4] pci: virtio_pci: Add SR-IOV support for virtio_pci devices

2018-02-26 Thread Alexander Duyck
On Sun, Feb 25, 2018 at 8:48 PM, Mark Rustad wrote: > Hardware-realized virtio_pci devices can implement SR-IOV, so this > patch enables its use. The device in question is an upcoming Intel > NIC that implements both a virtio_net PF and virtio_net VFs. These > are hardware realizations of what has

[RFC PATCH V4] pci: virtio_pci: Add SR-IOV support for virtio_pci devices

2018-02-25 Thread Mark Rustad
Hardware-realized virtio_pci devices can implement SR-IOV, so this patch enables its use. The device in question is an upcoming Intel NIC that implements both a virtio_net PF and virtio_net VFs. These are hardware realizations of what has been up to now been a software interface. The device in que