Re: [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf

2008-02-21 Thread Vlad Yasevich
Ilpo Järvinen wrote: On Wed, 20 Feb 2008, Vlad Yasevich wrote: Ilpo Järvinen wrote: I added inline to sctp_add_cmd and appropriate comment there to avoid adding another call into the call chain. This works at least with "gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)". Alternatively, __sctp_add_c

Re: [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf

2008-02-20 Thread Ilpo Järvinen
On Wed, 20 Feb 2008, Vlad Yasevich wrote: > Ilpo Järvinen wrote: > > I added inline to sctp_add_cmd and appropriate comment there to > > avoid adding another call into the call chain. This works at least > > with "gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)". Alternatively, > > __sctp_add_cmd coul

Re: [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf

2008-02-20 Thread Vlad Yasevich
Ilpo Järvinen wrote: I added inline to sctp_add_cmd and appropriate comment there to avoid adding another call into the call chain. This works at least with "gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)". Alternatively, __sctp_add_cmd could be introduced to .h. My only concern was performance r

[RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf

2008-02-20 Thread Ilpo Järvinen
I added inline to sctp_add_cmd and appropriate comment there to avoid adding another call into the call chain. This works at least with "gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)". Alternatively, __sctp_add_cmd could be introduced to .h. net/sctp/sm_statefuns.c: sctp_sf_cookie_wait_prm_abort