Re: [RFC PATCH 3/4] udp: implement GRO plain UDP sockets.

2018-09-17 Thread Paolo Abeni
Hi, On Fri, 2018-09-14 at 09:48 -0700, Eric Dumazet wrote: > Are you sure the data is actually fully copied to user space ? > > tools/testing/selftests/net/udpgso_bench_rx.c > > uses : > > static char rbuf[ETH_DATA_LEN]; >/* MSG_TRUNC will make return value full datagram length */ >ret

Re: [RFC PATCH 3/4] udp: implement GRO plain UDP sockets.

2018-09-14 Thread Eric Dumazet
On 09/14/2018 08:43 AM, Paolo Abeni wrote: > This is the RX counter part of commit bec1f6f69736 ("udp: generate gso > with UDP_SEGMENT"). When UDP_SEGMENT is enabled, such socket is also > eligible for GRO in the rx path: UDP segments directed to such socket > are assembled into a larger GSO_UDP

[RFC PATCH 3/4] udp: implement GRO plain UDP sockets.

2018-09-14 Thread Paolo Abeni
This is the RX counter part of commit bec1f6f69736 ("udp: generate gso with UDP_SEGMENT"). When UDP_SEGMENT is enabled, such socket is also eligible for GRO in the rx path: UDP segments directed to such socket are assembled into a larger GSO_UDP_L4 packet. The core UDP GRO support is enabled/updat