Re: [RFC PATCH 2/4] page_pool: basic implementation of page_pool

2017-01-10 Thread Jesper Dangaard Brouer
On Mon, 9 Jan 2017 21:58:26 + Mel Gorman wrote: > On Mon, Jan 09, 2017 at 09:45:24PM +0100, Jesper Dangaard Brouer wrote: > > > I see. I guess if all page pool pages were order>0 compound pages, you > > > could hook this to the existing compound_dtor functionality instead. > > > > The page

Re: [RFC PATCH 2/4] page_pool: basic implementation of page_pool

2017-01-09 Thread Mel Gorman
On Mon, Jan 09, 2017 at 09:45:24PM +0100, Jesper Dangaard Brouer wrote: > > I see. I guess if all page pool pages were order>0 compound pages, you > > could hook this to the existing compound_dtor functionality instead. > > The page_pool will support order>0 pages, but it is the order-0 case > tha

Re: [RFC PATCH 2/4] page_pool: basic implementation of page_pool

2017-01-09 Thread Jesper Dangaard Brouer
On Mon, 9 Jan 2017 11:43:39 +0100 Vlastimil Babka wrote: > On 01/04/2017 12:00 PM, Jesper Dangaard Brouer wrote: > > > > On Tue, 3 Jan 2017 17:07:49 +0100 Vlastimil Babka wrote: > > > >> On 12/20/2016 02:28 PM, Jesper Dangaard Brouer wrote: > >>> The focus in this patch is getting the API

Re: [RFC PATCH 2/4] page_pool: basic implementation of page_pool

2017-01-09 Thread Vlastimil Babka
On 01/04/2017 12:00 PM, Jesper Dangaard Brouer wrote: > > On Tue, 3 Jan 2017 17:07:49 +0100 Vlastimil Babka wrote: > >> On 12/20/2016 02:28 PM, Jesper Dangaard Brouer wrote: >>> The focus in this patch is getting the API around page_pool figured out. >>> >>> The internal data structures for retu

Re: [RFC PATCH 2/4] page_pool: basic implementation of page_pool

2017-01-04 Thread Jesper Dangaard Brouer
On Tue, 3 Jan 2017 17:07:49 +0100 Vlastimil Babka wrote: > On 12/20/2016 02:28 PM, Jesper Dangaard Brouer wrote: > > The focus in this patch is getting the API around page_pool figured out. > > > > The internal data structures for returning page_pool pages is not optimal. > > This implementation

Re: [RFC PATCH 2/4] page_pool: basic implementation of page_pool

2017-01-03 Thread Vlastimil Babka
On 12/20/2016 02:28 PM, Jesper Dangaard Brouer wrote: The focus in this patch is getting the API around page_pool figured out. The internal data structures for returning page_pool pages is not optimal. This implementation use ptr_ring for recycling, which is known not to scale in case of multipl

[RFC PATCH 2/4] page_pool: basic implementation of page_pool

2016-12-20 Thread Jesper Dangaard Brouer
The focus in this patch is getting the API around page_pool figured out. The internal data structures for returning page_pool pages is not optimal. This implementation use ptr_ring for recycling, which is known not to scale in case of multiple remote CPUs releasing/returning pages. A bulking inte