RE: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-18 Thread Rafal Ozieblo
Ferre; harini.kata...@xilinx.com; netdev@vger.kernel.org; >>> linux-ker...@vger.kernel.org >>> Subject:

Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-18 Thread Harini Katakam
tHi Andrei, >> Yes, Andre's version of Cadence does not ability to report have RX >> timestamp. >> The version I worked with did. This is the old series I sent: >> https://lkml.org/lkml/2015/9/11/92 >> But right now, i'm working on building on top of Andre's changes. > > > I'm addressing maintaine

Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-18 Thread Nicolas Ferre
>>>> >>>> Cc: harini.kata...@xilinx.com; netdev@vger.kernel.org; >>>> >>>

RE: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-18 Thread Rafal Ozieblo
>Cc: Nicolas Ferre; Andrei Pistirica; harini.kata...@xilinx.com; >netdev@vger.kernel.org; linux-ker...@vger.kernel.org > >Subject: Re: [RFC PATCH 2/2] net: macb: Add 64 bit

Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-18 Thread Harini Katakam
gt;> linux-ker...@vger.kernel.org >> Subject: Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM >> >> Hi Rafal, >> >> On Thu, Nov 17, 2016 at 7:05 PM, Rafal Ozieblo wrote: >> > -Original Message- >> > From: Nicolas Ferre

Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-18 Thread Andrei Pistirica
: harini.kata...@xilinx.com; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM Le 18/11/2016 à 09:59, Rafal Ozieblo a écrit : Hello, From: Harini Katakam [mailto:harinikatakamli...@gmail.com] Sent: 18 listopada 2016 05:30 To

Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-18 Thread Harini Katakam
Hi Rafal, > I can’t see a place where you enable extended descriptor for PTP. Did you add > support for extended PTP descriptor? Sorry, that was separate patch in the series: http://lkml.iu.edu/hypermail/linux/kernel/1509.1/02239.html > "DMA Configuration Register" 0x010: > 29 tx_bd_extend

RE: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-18 Thread Rafal Ozieblo
ernel.org >Subject: Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM > > > >Le 18/11/2016 à 09:59, Rafal Ozieblo a écrit :

Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-18 Thread Harini Katakam
nx.com; netdev@vger.kernel.org; >>linux-ker...@vger.kernel.org >>Subject: Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM >> >>Le 18/11/2016 à 09:59, Rafal Ozieblo a écrit : >>> Hello, >>> >>>> From: Harini Katakam [mailto:har

RE: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-18 Thread Rafal Ozieblo
; > Cc: harini.kata...@xilinx.com; netdev@vger.kernel.org; > > linux-ker...@vger.kernel.org > > Subject: Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support > > for GEM > > > >> Le 17/11/2016 à 13:21, Harini Katakam a écrit : > >> > Hi Rafal, &g

Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-18 Thread Nicolas Ferre
er...@vger.kernel.org >> Subject: Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM >> >> Hi Rafal, >> >> On Thu, Nov 17, 2016 at 7:05 PM, Rafal Ozieblo wrote: >>> -Original Message- >>> From: Nicolas Ferre [mailto:nicolas.fe..

Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-17 Thread Harini Katakam
g; > linux-ker...@vger.kernel.org > Subject: Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM > >> Le 17/11/2016 à 13:21, Harini Katakam a écrit : >> > Hi Rafal, >> > >> > On Thu, Nov 17, 2016 at 5:20 PM, Rafal Ozieblo wrote: &g

Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-17 Thread Harini Katakam
Hi Rafal, On Thu, Nov 17, 2016 at 5:20 PM, Rafal Ozieblo wrote: > Hello, > I think, there could a bug in your patch. > >> + >> +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT >> + dmacfg |= GEM_BIT(ADDR64); >> +#endif > > You enable 64 bit addressing (64b dma bus width) always when appropriate

RE: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-17 Thread Rafal Ozieblo
-Original Message- From: Nicolas Ferre [mailto:nicolas.fe...@atmel.com] Sent: 17 listopada 2016 14:29 To: Harini Katakam; Rafal Ozieblo Cc: harini.kata...@xilinx.com; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing

RE: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-17 Thread Rafal Ozieblo
-Original Message- From: Harini Katakam [mailto:harinikatakamli...@gmail.com] Sent: 17 listopada 2016 13:22 To: Rafal Ozieblo Cc: harini.kata...@xilinx.com; nicolas.fe...@atmel.com; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [RFC PATCH 2/2] net: macb: Add 64 bit

Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-17 Thread Nicolas Ferre
Le 17/11/2016 à 13:21, Harini Katakam a écrit : > Hi Rafal, > > On Thu, Nov 17, 2016 at 5:20 PM, Rafal Ozieblo wrote: >> Hello, >> I think, there could a bug in your patch. >> >>> + >>> +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT >>> + dmacfg |= GEM_BIT(ADDR64); >>> +#endif >> >> You enable

Re: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-11-17 Thread Rafal Ozieblo
Hello, I think, there could a bug in your patch. > + > +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT > + dmacfg |= GEM_BIT(ADDR64); > +#endif You enable 64 bit addressing (64b dma bus width) always when appropriate architecture config option is enabled. But there are some legacy controllers w

[RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

2016-08-01 Thread Harini Katakam
This patch adds support for 64 bit addressing and BDs. -> Enable 64 bit addressing in DMACFG register. -> Set DMA mask when design config register shows support for 64 bit addr. -> Add new BD words for higher address when 64 bit DMA support is present. -> Add and update TBQPH and RBQPH for MSB of B