Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

2016-12-05 Thread Nicolas Ferre
Le 05/12/2016 à 03:55, Harini Katakam a écrit : > Hi Rob, > > > Thanks for the review. > On Sun, Dec 4, 2016 at 3:05 AM, Rob Herring wrote: >> On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote: > >>> +Required properties: >>> +- compatible: Should be "cdns,macb-mdio" >> >> Only one

Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

2016-12-04 Thread Harini Katakam
Hi Florian, On Sun, Dec 4, 2016 at 4:10 AM, Florian Fainelli wrote: > Le 12/03/16 à 13:35, Rob Herring a écrit : >> On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote: >>> +- reg: Address and length of the register set of MAC to be used >>> +- clock-names: Tuple listing input clock na

Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

2016-12-04 Thread Harini Katakam
Hi Rob, Thanks for the review. On Sun, Dec 4, 2016 at 3:05 AM, Rob Herring wrote: > On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote: >> +Required properties: >> +- compatible: Should be "cdns,macb-mdio" > > Only one version ever? This needs more specific compatible strings. > Th

Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

2016-12-03 Thread Florian Fainelli
Le 12/03/16 à 13:35, Rob Herring a écrit : > On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote: >> Add documentations for macb mdio driver. > > Bindings document h/w, not drivers. > >> >> Signed-off-by: Harini Katakam >> --- >> .../devicetree/bindings/net/macb-mdio.txt | 3

Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

2016-12-03 Thread Rob Herring
On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote: > Add documentations for macb mdio driver. Bindings document h/w, not drivers. > > Signed-off-by: Harini Katakam > --- > .../devicetree/bindings/net/macb-mdio.txt | 31 > ++ > 1 file changed, 31 inser

[RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

2016-11-28 Thread Harini Katakam
Add documentations for macb mdio driver. Signed-off-by: Harini Katakam --- .../devicetree/bindings/net/macb-mdio.txt | 31 ++ 1 file changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/macb-mdio.txt diff --git a/Documentation/devicetr

Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

2016-05-13 Thread Harini Katakam
HI Andrew, On Fri, May 13, 2016 at 11:13 PM, Andrew Lunn wrote: > Hi Harini > > Is this backward compatible? Will devices using the old binding still > work? It isn't right now. I will have to assign the bus read/write functions conditionally in order to do that - I'll see if I can make it clean

Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

2016-05-13 Thread Andrew Lunn
Hi Harini Is this backward compatible? Will devices using the old binding still work? /* Disable RX and TX (XXX: Should we halt the transmission * more gracefully?) */ - macb_writel(bp, NCR, 0); + ctrl = macb_readl(bp, NCR); + ctrl &= ~(MACB_BIT(RE) | MACB_BIT(TE)); + macb_writel

Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

2016-05-13 Thread Andrew Lunn
> + mdio { > + compatible = "cdns,macb-mdio"; > + reg = <0x0 0xff0b 0x0 0x1000>; > + clocks = <&clk125>, <&clk125>, <&clk125>; > + clock-names = "pclk", "hclk", "tx_clk"; > + ethernet_phyC: ethernet-phy@C { > +

[RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

2016-05-13 Thread Harini Katakam
Add documentations for macb mdio driver. Signed-off-by: Harini Katakam --- .../devicetree/bindings/net/macb-mdio.txt | 31 1 file changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/macb-mdio.txt diff --git a/Documentation/devicetr