Re: [RFC PATCH 1/5] net: lorawan: Refine the coding style

2019-01-16 Thread Jian-Hong Pan
Andreas Färber 於 2019年1月16日 週三 下午11:07寫道: > > Am 16.01.19 um 15:33 schrieb Jiri Pirko: > > Wed, Jan 16, 2019 at 03:24:54PM CET, starni...@g.ncu.edu.tw wrote: > >> Signed-off-by: Jian-Hong Pan > >> --- > > > > Patches like this are in general frowned upon. Do one change in one > > patch. Put some

Re: [RFC PATCH 1/5] net: lorawan: Refine the coding style

2019-01-16 Thread Andreas Färber
Am 16.01.19 um 15:33 schrieb Jiri Pirko: > Wed, Jan 16, 2019 at 03:24:54PM CET, starni...@g.ncu.edu.tw wrote: >> Signed-off-by: Jian-Hong Pan >> --- > > Patches like this are in general frowned upon. Do one change in one > patch. Put some patch description. This patch simply shouldn't have gone

Re: [RFC PATCH 1/5] net: lorawan: Refine the coding style

2019-01-16 Thread Jiri Pirko
Wed, Jan 16, 2019 at 03:24:54PM CET, starni...@g.ncu.edu.tw wrote: >Signed-off-by: Jian-Hong Pan >--- Patches like this are in general frowned upon. Do one change in one patch. Put some patch description.

[RFC PATCH 1/5] net: lorawan: Refine the coding style

2019-01-16 Thread Jian-Hong Pan
Signed-off-by: Jian-Hong Pan --- include/linux/lora/lorawan_netdev.h | 5 ++-- net/lorawan/socket.c| 43 ++--- 2 files changed, 22 insertions(+), 26 deletions(-) diff --git a/include/linux/lora/lorawan_netdev.h b/include/linux/lora/lorawan_netdev.h index