Re: [RFC PATCH 1/2] regmap: add miim bus support

2021-04-09 Thread Andrew Lunn
On Fri, Apr 09, 2021 at 07:16:42PM +0100, Mark Brown wrote: > On Fri, Apr 09, 2021 at 08:14:22PM +0200, Sander Vanheule wrote: > > > The kernel has the mii_bus struct to describe the bus master, but like > > you noted the bus is generaly refered to as an MDIO interface. I'm fine > > with naming it

Re: [RFC PATCH 1/2] regmap: add miim bus support

2021-04-09 Thread Mark Brown
On Fri, Apr 09, 2021 at 08:14:22PM +0200, Sander Vanheule wrote: > The kernel has the mii_bus struct to describe the bus master, but like > you noted the bus is generaly refered to as an MDIO interface. I'm fine > with naming it MDIO to make it easier to spot. Either mii_bus or mdio seem like an

Re: [RFC PATCH 1/2] regmap: add miim bus support

2021-04-09 Thread Sander Vanheule
Hi Mark, On Fri, 2021-04-09 at 17:07 +0100, Mark Brown wrote: > On Thu, Apr 08, 2021 at 10:52:34PM +0200, Sander Vanheule wrote: > > Basic support for MIIM bus access. Support only includes clause-22 > > register access, with 5-bit addresses, and 16-bit wide registers. > > What is "MIIM"?  A quic

Re: [RFC PATCH 1/2] regmap: add miim bus support

2021-04-09 Thread Mark Brown
On Thu, Apr 08, 2021 at 10:52:34PM +0200, Sander Vanheule wrote: > Basic support for MIIM bus access. Support only includes clause-22 > register access, with 5-bit addresses, and 16-bit wide registers. What is "MIIM"? A quick search isn't showing up useful hits for that. Why not just call this MD

[RFC PATCH 1/2] regmap: add miim bus support

2021-04-08 Thread Sander Vanheule
Basic support for MIIM bus access. Support only includes clause-22 register access, with 5-bit addresses, and 16-bit wide registers. Signed-off-by: Sander Vanheule --- drivers/base/regmap/Kconfig | 6 +++- drivers/base/regmap/Makefile | 1 + drivers/base/regmap/regmap-miim.c | 58 ++