Re: [RFC PATCH 03/17] net: sched: remove remaining uses for qdisc_qlen in xmit path

2017-11-15 Thread John Fastabend
On 11/14/2017 05:56 PM, Willem de Bruijn wrote: > On Tue, Nov 14, 2017 at 7:11 PM, Willem de Bruijn > wrote: >> On Mon, Nov 13, 2017 at 3:08 PM, John Fastabend >> wrote: >>> sch_direct_xmit() uses qdisc_qlen as a return value but all call sites >>> of the routine only check if it is zero or not.

Re: [RFC PATCH 03/17] net: sched: remove remaining uses for qdisc_qlen in xmit path

2017-11-14 Thread Willem de Bruijn
On Tue, Nov 14, 2017 at 7:11 PM, Willem de Bruijn wrote: > On Mon, Nov 13, 2017 at 3:08 PM, John Fastabend > wrote: >> sch_direct_xmit() uses qdisc_qlen as a return value but all call sites >> of the routine only check if it is zero or not. Simplify the logic so >> that we don't need to return an

Re: [RFC PATCH 03/17] net: sched: remove remaining uses for qdisc_qlen in xmit path

2017-11-14 Thread Willem de Bruijn
On Mon, Nov 13, 2017 at 3:08 PM, John Fastabend wrote: > sch_direct_xmit() uses qdisc_qlen as a return value but all call sites > of the routine only check if it is zero or not. Simplify the logic so > that we don't need to return an actual queue length value. > > This introduces a case now where

[RFC PATCH 03/17] net: sched: remove remaining uses for qdisc_qlen in xmit path

2017-11-13 Thread John Fastabend
sch_direct_xmit() uses qdisc_qlen as a return value but all call sites of the routine only check if it is zero or not. Simplify the logic so that we don't need to return an actual queue length value. This introduces a case now where sch_direct_xmit would have returned a qlen of zero but now it ret

[RFC PATCH 03/17] net: sched: remove remaining uses for qdisc_qlen in xmit path

2017-05-02 Thread John Fastabend
sch_direct_xmit() uses qdisc_qlen as a return value but all call sites of the routine only check if it is zero or not. Simplify the logic so that we don't need to return an actual queue length value. This introduces a case now where sch_direct_xmit would have returned a qlen of zero but now it ret