Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-18 Thread Willem de Bruijn
> > > What it does not give is a type indication, such as > > > VIRTIO_NET_HASH_TYPE_TCPv6. I don't understand how this would be used. > > > In datapaths where the NIC has already computed the four-tuple hash > > > and stored it in skb->hash --the common case for servers--, That typ

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-18 Thread Yuri Benditovich
On Mon, Jan 18, 2021 at 4:46 AM Jason Wang wrote: > > > On 2021/1/17 下午3:57, Yuri Benditovich wrote: > > On Thu, Jan 14, 2021 at 5:39 AM Jason Wang wrote: > >> > >> On 2021/1/13 下午10:33, Willem de Bruijn wrote: > >>> On Tue, Jan 12, 2021 at 11:11 PM Jason Wang wrote: > On 2021/1/13 上午7:47,

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-17 Thread Jason Wang
On 2021/1/17 下午3:57, Yuri Benditovich wrote: On Thu, Jan 14, 2021 at 5:39 AM Jason Wang wrote: On 2021/1/13 下午10:33, Willem de Bruijn wrote: On Tue, Jan 12, 2021 at 11:11 PM Jason Wang wrote: On 2021/1/13 上午7:47, Willem de Bruijn wrote: On Tue, Jan 12, 2021 at 3:29 PM Yuri Benditovich w

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-17 Thread Yuri Benditovich
On Thu, Jan 14, 2021 at 5:39 AM Jason Wang wrote: > > > On 2021/1/13 下午10:33, Willem de Bruijn wrote: > > On Tue, Jan 12, 2021 at 11:11 PM Jason Wang wrote: > >> > >> On 2021/1/13 上午7:47, Willem de Bruijn wrote: > >>> On Tue, Jan 12, 2021 at 3:29 PM Yuri Benditovich > >>> wrote: > On Tue, J

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-13 Thread Jason Wang
On 2021/1/13 下午10:33, Willem de Bruijn wrote: On Tue, Jan 12, 2021 at 11:11 PM Jason Wang wrote: On 2021/1/13 上午7:47, Willem de Bruijn wrote: On Tue, Jan 12, 2021 at 3:29 PM Yuri Benditovich wrote: On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich wrote: On Tue, Jan 12, 2021 at 9:41 PM Y

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-13 Thread Willem de Bruijn
On Tue, Jan 12, 2021 at 11:11 PM Jason Wang wrote: > > > On 2021/1/13 上午7:47, Willem de Bruijn wrote: > > On Tue, Jan 12, 2021 at 3:29 PM Yuri Benditovich > > wrote: > >> On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich > >> wrote: > >>> On Tue, Jan 12, 2021 at 9:41 PM Yuri Benditovich > >>> wr

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-12 Thread Jason Wang
On 2021/1/13 上午7:47, Willem de Bruijn wrote: On Tue, Jan 12, 2021 at 3:29 PM Yuri Benditovich wrote: On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich wrote: On Tue, Jan 12, 2021 at 9:41 PM Yuri Benditovich wrote: Existing TUN module is able to use provided "steering eBPF" to calculate per

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-12 Thread Willem de Bruijn
On Tue, Jan 12, 2021 at 3:29 PM Yuri Benditovich wrote: > > On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich > wrote: > > > > On Tue, Jan 12, 2021 at 9:41 PM Yuri Benditovich > > wrote: > > > > > > Existing TUN module is able to use provided "steering eBPF" to > > > calculate per-packet hash and

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-12 Thread Yuri Benditovich
On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich wrote: > > On Tue, Jan 12, 2021 at 9:41 PM Yuri Benditovich > wrote: > > > > Existing TUN module is able to use provided "steering eBPF" to > > calculate per-packet hash and derive the destination queue to > > place the packet to. The eBPF uses map

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-12 Thread Yuri Benditovich
On Tue, Jan 12, 2021 at 9:41 PM Yuri Benditovich wrote: > > Existing TUN module is able to use provided "steering eBPF" to > calculate per-packet hash and derive the destination queue to > place the packet to. The eBPF uses mapped configuration data > containing a key for hash calculation and indi

[RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-12 Thread Yuri Benditovich
Existing TUN module is able to use provided "steering eBPF" to calculate per-packet hash and derive the destination queue to place the packet to. The eBPF uses mapped configuration data containing a key for hash calculation and indirection table with array of queues' indices. This series of patche

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-12 Thread Yuri Benditovich
Sorry for misunderstanding, I'll resend _all_ the patches to all the maintainers and copy existing comments for further discussion On Tue, Jan 5, 2021 at 7:21 PM Willem de Bruijn wrote: > > On Tue, Jan 5, 2021 at 8:12 AM Yuri Benditovich > wrote: > > > > Existing TUN module is able to use provid

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-05 Thread Willem de Bruijn
On Tue, Jan 5, 2021 at 8:12 AM Yuri Benditovich wrote: > > Existing TUN module is able to use provided "steering eBPF" to > calculate per-packet hash and derive the destination queue to > place the packet to. The eBPF uses mapped configuration data > containing a key for hash calculation and indir

[RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-05 Thread Yuri Benditovich
Existing TUN module is able to use provided "steering eBPF" to calculate per-packet hash and derive the destination queue to place the packet to. The eBPF uses mapped configuration data containing a key for hash calculation and indirection table with array of queues' indices. This series of patche