Re: [RFC PATCH 0/1] net: arcnet: Fix RESET sequence

2021-01-18 Thread Jakub Kicinski
On Mon, 18 Jan 2021 11:45:44 +0100 Ahmed S. Darwish wrote: > On Mon, Jan 11, 2021 at 02:54:06PM +0100, Ahmed S. Darwish wrote: > > Hi, > > > > On Tue, Dec 22, 2020 at 10:03:37AM +0100, Ahmed S. Darwish wrote: > > ... > > > > > > Included is an RFC patch to fix the points above: if the RESET flag

Re: [RFC PATCH 0/1] net: arcnet: Fix RESET sequence

2021-01-18 Thread Ahmed S. Darwish
On Mon, Jan 11, 2021 at 02:54:06PM +0100, Ahmed S. Darwish wrote: > Hi, > > On Tue, Dec 22, 2020 at 10:03:37AM +0100, Ahmed S. Darwish wrote: > ... > > > > Included is an RFC patch to fix the points above: if the RESET flag is > > encountered, a workqueue is scheduled to run the generic reset seque

Re: [RFC PATCH 0/1] net: arcnet: Fix RESET sequence

2021-01-11 Thread Ahmed S. Darwish
Hi, On Tue, Dec 22, 2020 at 10:03:37AM +0100, Ahmed S. Darwish wrote: ... > > Included is an RFC patch to fix the points above: if the RESET flag is > encountered, a workqueue is scheduled to run the generic reset sequence. > ... Kind reminder.

Re: [RFC PATCH 0/1] net: arcnet: Fix RESET sequence

2021-01-11 Thread Sebastian A. Siewior
On 2020-12-22 10:03:37 [+0100], Ahmed S. Darwish wrote: > 2) arcnet_close() contains a del_timer_sync(). If the irq handler > interrupts the to-be-deleted timer then call del_timer_sync(), it > will just loop forever. del_timer_sync() will trigger a warning if invoked from interrupt ha

[RFC PATCH 0/1] net: arcnet: Fix RESET sequence

2020-12-22 Thread Ahmed S. Darwish
Folks, At drivers/net/arcnet/arcnet.c, there is: irqreturn_t arcnet_interrupt(int irq, void *dev_id) { ... if (status & RESETflag) { arcnet_close(dev); arcnet_open(dev); } ... } struct net_device_ops arcnet_netdev_ops = {