Re: [RFC PATCH] slub: RFC: Improving SLUB performance with 38% on NO-PREEMPT

2015-06-08 Thread Jesper Dangaard Brouer
On Mon, 8 Jun 2015 04:39:38 -0500 (CDT) Christoph Lameter wrote: > On Mon, 8 Jun 2015, Jesper Dangaard Brouer wrote: > > > My real question is if disabling local interrupts is enough to avoid this? > > Yes the initial release of slub used interrupt disable in the fast paths. Thanks for the con

Re: [RFC PATCH] slub: RFC: Improving SLUB performance with 38% on NO-PREEMPT

2015-06-08 Thread Christoph Lameter
On Mon, 8 Jun 2015, Jesper Dangaard Brouer wrote: > My real question is if disabling local interrupts is enough to avoid this? Yes the initial release of slub used interrupt disable in the fast paths. > And, does local irq disabling also stop preemption? Of course. -- To unsubscribe from this

Re: [RFC PATCH] slub: RFC: Improving SLUB performance with 38% on NO-PREEMPT

2015-06-08 Thread Jesper Dangaard Brouer
On Thu, 04 Jun 2015 19:37:57 -0700 Eric Dumazet wrote: > On Thu, 2015-06-04 at 12:31 +0200, Jesper Dangaard Brouer wrote: > > This patch improves performance of SLUB allocator fastpath with 38% by > > avoiding the call to this_cpu_cmpxchg_double() for NO-PREEMPT kernels. > > > > Reviewers please

Re: [RFC PATCH] slub: RFC: Improving SLUB performance with 38% on NO-PREEMPT

2015-06-04 Thread Eric Dumazet
On Thu, 2015-06-04 at 12:31 +0200, Jesper Dangaard Brouer wrote: > This patch improves performance of SLUB allocator fastpath with 38% by > avoiding the call to this_cpu_cmpxchg_double() for NO-PREEMPT kernels. > > Reviewers please point out why this change is wrong, as such a large > improvement

[RFC PATCH] slub: RFC: Improving SLUB performance with 38% on NO-PREEMPT

2015-06-04 Thread Jesper Dangaard Brouer
This patch improves performance of SLUB allocator fastpath with 38% by avoiding the call to this_cpu_cmpxchg_double() for NO-PREEMPT kernels. Reviewers please point out why this change is wrong, as such a large improvement should not be possible ;-) My primarily motivation for this patch is to un