Re: [RFC PATCH] net act_vlan: use correct len in skb_pull

2019-02-14 Thread Zahari Doychev
On Thu, Feb 14, 2019 at 06:16:12PM +0900, Toshiaki Makita wrote: > On 2019/02/14 4:51, Zahari Doychev wrote: > > The bridge and VLAN code expects that skb->data points to the start of the > > VLAN header instead of the next (network) header. Currently after > > tcf_vlan_act() on ingress filter skb-

Re: [RFC PATCH] net act_vlan: use correct len in skb_pull

2019-02-14 Thread Toshiaki Makita
On 2019/02/14 4:51, Zahari Doychev wrote: > The bridge and VLAN code expects that skb->data points to the start of the > VLAN header instead of the next (network) header. Currently after > tcf_vlan_act() on ingress filter skb->data points to the next network > header. In this case the Linux bridge

[RFC PATCH] net act_vlan: use correct len in skb_pull

2019-02-13 Thread Zahari Doychev
The bridge and VLAN code expects that skb->data points to the start of the VLAN header instead of the next (network) header. Currently after tcf_vlan_act() on ingress filter skb->data points to the next network header. In this case the Linux bridge does not forward correctly double tagged VLAN pack