Re: [RFC PATCH] net: dsa: microchip: delete dead code

2020-07-25 Thread Andrew Lunn
On Thu, Jul 23, 2020 at 06:24:31AM +0200, Helmut Grohne wrote: > Hi Andrew, > > On Wed, Jul 22, 2020 at 04:39:53PM +0200, Andrew Lunn wrote: > > This patch probably is correct. But it is not obviously correct, > > because there are so many changes at once. Please could you break it > > up. > > >F

Re: [RFC PATCH] net: dsa: microchip: delete dead code

2020-07-22 Thread Helmut Grohne
Hi Andrew, On Wed, Jul 22, 2020 at 04:39:53PM +0200, Andrew Lunn wrote: > This patch probably is correct. But it is not obviously correct, > because there are so many changes at once. Please could you break it > up. >From my pov, it is less a question of whether it is correct, but whether it goes

Re: [RFC PATCH] net: dsa: microchip: delete dead code

2020-07-22 Thread Andrew Lunn
On Tue, Jul 21, 2020 at 10:33:01AM +0200, Helmut Grohne wrote: > None of the removed assignments is ever read back and never influences > logic. > > Signed-off-by: Helmut Grohne Hi Helmut This patch probably is correct. But it is not obviously correct, because there are so many changes at once.

[RFC PATCH] net: dsa: microchip: delete dead code

2020-07-21 Thread Helmut Grohne
None of the removed assignments is ever read back and never influences logic. Signed-off-by: Helmut Grohne --- drivers/net/dsa/microchip/ksz8795.c| 26 ++ drivers/net/dsa/microchip/ksz9477.c| 30 +- drivers/net/dsa/microchip/ksz_common.c | 23 -