Re: [RFC PATCH] net: Require socket to allow XPS to set queue mapping

2016-09-21 Thread Willem de Bruijn
On Thu, Aug 25, 2016 at 5:28 PM, Rick Jones wrote: > On 08/25/2016 02:08 PM, Eric Dumazet wrote: >> >> When XPS was submitted, it was _not_ enabled by default and 'magic' >> >> Some NIC vendors decided it was a good thing, you should complain to >> them ;) > > > I kindasorta am with the emails I'v

Re: [RFC PATCH] net: Require socket to allow XPS to set queue mapping

2016-08-25 Thread Tom Herbert
On Thu, Aug 25, 2016 at 12:49 PM, Eric Dumazet wrote: > On Thu, 2016-08-25 at 12:23 -0700, Alexander Duyck wrote: >> I have been seeing a number of issues where XPS leads to issues with >> packets being reordered in the transmit queues of the device drivers. The >> main situation where this seems

Re: [RFC PATCH] net: Require socket to allow XPS to set queue mapping

2016-08-25 Thread Rick Jones
On 08/25/2016 02:08 PM, Eric Dumazet wrote: When XPS was submitted, it was _not_ enabled by default and 'magic' Some NIC vendors decided it was a good thing, you should complain to them ;) I kindasorta am with the emails I've been sending to netdev :) And also hopefully precluding others goi

Re: [RFC PATCH] net: Require socket to allow XPS to set queue mapping

2016-08-25 Thread Alexander Duyck
On Thu, Aug 25, 2016 at 1:32 PM, Rick Jones wrote: > On 08/25/2016 12:49 PM, Eric Dumazet wrote: >> >> On Thu, 2016-08-25 at 12:23 -0700, Alexander Duyck wrote: >>> >>> A simpler approach is provided with this patch. With it we disable XPS >>> any >>> time a socket is not present for a given flow

Re: [RFC PATCH] net: Require socket to allow XPS to set queue mapping

2016-08-25 Thread Eric Dumazet
On Thu, 2016-08-25 at 13:32 -0700, Rick Jones wrote: > On 08/25/2016 12:49 PM, Eric Dumazet wrote: > > On Thu, 2016-08-25 at 12:23 -0700, Alexander Duyck wrote: > >> A simpler approach is provided with this patch. With it we disable XPS any > >> time a socket is not present for a given flow. By d

Re: [RFC PATCH] net: Require socket to allow XPS to set queue mapping

2016-08-25 Thread Rick Jones
On 08/25/2016 12:49 PM, Eric Dumazet wrote: On Thu, 2016-08-25 at 12:23 -0700, Alexander Duyck wrote: A simpler approach is provided with this patch. With it we disable XPS any time a socket is not present for a given flow. By doing this we can avoid using XPS for any routing or bridging situa

Re: [RFC PATCH] net: Require socket to allow XPS to set queue mapping

2016-08-25 Thread Eric Dumazet
On Thu, 2016-08-25 at 12:23 -0700, Alexander Duyck wrote: > I have been seeing a number of issues where XPS leads to issues with > packets being reordered in the transmit queues of the device drivers. The > main situation where this seems to occur is when a VM us using a tap > interface to send pa

[RFC PATCH] net: Require socket to allow XPS to set queue mapping

2016-08-25 Thread Alexander Duyck
I have been seeing a number of issues where XPS leads to issues with packets being reordered in the transmit queues of the device drivers. The main situation where this seems to occur is when a VM us using a tap interface to send packets to the network via a NIC that has XPS enabled. A bit of loo