Re: [RFC PATCH] intel: Use upper_32_bits and lower_32_bits

2017-01-09 Thread Joe Perches
On Mon, 2017-01-09 at 12:55 +, David Laight wrote: > From: Joe Perches > > Sent: 07 January 2017 18:33 > > Shifting and masking various types can be made a bit > > simpler to read by using the available kernel macros. > > ... > > - ew32(TDBAH, (tdba >> 32)); > > - ew32(TDBA

RE: [RFC PATCH] intel: Use upper_32_bits and lower_32_bits

2017-01-09 Thread David Laight
From: Joe Perches > Sent: 07 January 2017 18:33 > Shifting and masking various types can be made a bit > simpler to read by using the available kernel macros. ... > - ew32(TDBAH, (tdba >> 32)); > - ew32(TDBAL, (tdba & 0xULL)); > + ew32(TDBAH, uppe

Re: [RFC PATCH] intel: Use upper_32_bits and lower_32_bits

2017-01-07 Thread Julia Lawall
On Sat, 7 Jan 2017, Joe Perches wrote: > Shifting and masking various types can be made a bit > simpler to read by using the available kernel macros. It looks much nicer to me, especially in the lower case, where there are multiple ways to express the same thing. julia > > Signed-off-by: Joe P

[RFC PATCH] intel: Use upper_32_bits and lower_32_bits

2017-01-07 Thread Joe Perches
Shifting and masking various types can be made a bit simpler to read by using the available kernel macros. Signed-off-by: Joe Perches --- This RFC patch is meant as an example, not necessarily to apply, though it does compile to equivalent code. It does seem a bit simpler for a human to read.