Re: [RFC PATCH] Fix: ipv4/icmp: icmp error route lookup performed on wrong routing table

2020-07-22 Thread David Ahern
On 7/22/20 11:26 AM, Mathieu Desnoyers wrote: > Adding IPv4/IPv6 maintainers in CC, along with David Ahern's k.org email > address. > > - On Jul 20, 2020, at 6:11 PM, Mathieu Desnoyers > mathieu.desnoy...@efficios.com wrote: > >> As per RFC792, ICMP errors should be sent to the source host.

Re: [RFC PATCH] Fix: ipv4/icmp: icmp error route lookup performed on wrong routing table

2020-07-22 Thread Mathieu Desnoyers
Adding IPv4/IPv6 maintainers in CC, along with David Ahern's k.org email address. - On Jul 20, 2020, at 6:11 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > As per RFC792, ICMP errors should be sent to the source host. > > However, in configurations with Virtual Forwarding an

[RFC PATCH] Fix: ipv4/icmp: icmp error route lookup performed on wrong routing table

2020-07-20 Thread Mathieu Desnoyers
As per RFC792, ICMP errors should be sent to the source host. However, in configurations with Virtual Forwarding and Routing tables, looking up which routing table to use is currently done by using the destination net_device. commit 9d1a6c4ea43e ("net: icmp_route_lookup should use rt dev to deter