Re: [RFC PATCH] EtherIP tunnel driver (RFC 3387)

2006-09-03 Thread Patrick McHardy
Joerg Roedel wrote: > On Fri, Sep 01, 2006 at 06:24:56PM +0200, Patrick McHardy wrote: >> >>>+fl.oif = 0; >>>+fl.nl_u.ip4_u.daddr = tunnel->parms.iph.daddr; >>>+fl.nl_u.ip4_u.saddr = tunnel->parms.iph.saddr; >>>+fl.nl_u.ip4_u.saddr = 0; >>>+fl.proto = IPPROTO_ETHERIP; >> >>This

Re: [RFC PATCH] EtherIP tunnel driver (RFC 3387)

2006-09-03 Thread Joerg Roedel
On Fri, Sep 01, 2006 at 06:24:56PM +0200, Patrick McHardy wrote: Hello Patrick, Thank you very much for reviewing my driver. I will fix the issues you mentioned. But I have some explanations and questions left. > Joerg Roedel wrote: > > + fl.oif = 0; > > + fl.nl_u.ip4_u.daddr = tunnel->parms

Re: [RFC PATCH] EtherIP tunnel driver (RFC 3387)

2006-09-01 Thread Patrick McHardy
Joerg Roedel wrote: > diff -uprN linux-2.6.17.11-vanilla/net/ipv4/etherip.c > linux-2.6.17.11/net/ipv4/etherip.c > --- linux-2.6.17.11-vanilla/net/ipv4/etherip.c1970-01-01 > 01:00:00.0 +0100 > +++ linux-2.6.17.11/net/ipv4/etherip.c2006-09-01 16:22:54.0 > +0200 >

[RFC PATCH] EtherIP tunnel driver (RFC 3387)

2006-09-01 Thread Joerg Roedel
Greetings, Upon request of a BSD user I wrote an EtherIP tunnel driver for the Linux Kernel. With this driver it is possible to tunnel Ethernet packets over IPv4 networks using the EtherIP protocol defined in RFC 3378. This RFC defines the EtherIP header to be a 16 bit field with the first 4 bit