Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-31 Thread Scott Feldman
On Fri, May 29, 2015 at 3:57 PM, Vivien Didelot wrote: > Scott, > > Can I ask details about this NETIF_F_HW_SWITCH_OFFLOAD flag? Why is it > unneeded? Sorry, the commit message for that changes wasn't very good because it didn't capture the email discussion leading up. The issue I had with the

Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-29 Thread Vivien Didelot
On May 29, 2015, at 6:15 PM, Guenter Roeck li...@roeck-us.net wrote: > On 05/29/2015 08:51 AM, Or Gerlitz wrote: >> On Fri, May 29, 2015 at 6:38 PM, Vivien Didelot >> wrote: >>> Hi, >>> >>> - On May 29, 2015, at 11:24 AM, Or Gerlitz gerlitz...@gmail.com wrote: >>> On Fri, May 29, 2015 a

Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-29 Thread Guenter Roeck
On 05/29/2015 08:51 AM, Or Gerlitz wrote: On Fri, May 29, 2015 at 6:38 PM, Vivien Didelot wrote: Hi, - On May 29, 2015, at 11:24 AM, Or Gerlitz gerlitz...@gmail.com wrote: On Fri, May 29, 2015 at 12:37 AM, Vivien Didelot wrote: @@ -854,7 +922,9 @@ int dsa_slave_create(struct dsa_switch

Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-29 Thread Or Gerlitz
On Fri, May 29, 2015 at 6:38 PM, Vivien Didelot wrote: > Hi, > > - On May 29, 2015, at 11:24 AM, Or Gerlitz gerlitz...@gmail.com wrote: > >> On Fri, May 29, 2015 at 12:37 AM, Vivien Didelot >> wrote: >>> @@ -854,7 +922,9 @@ int dsa_slave_create(struct dsa_switch *ds, struct >>> device >>> *p

Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-29 Thread Vivien Didelot
Hi, - On May 29, 2015, at 11:24 AM, Or Gerlitz gerlitz...@gmail.com wrote: > On Fri, May 29, 2015 at 12:37 AM, Vivien Didelot > wrote: >> @@ -854,7 +922,9 @@ int dsa_slave_create(struct dsa_switch *ds, struct device >> *parent, >> if (slave_dev == NULL) >> return -ENO

Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-29 Thread Or Gerlitz
On Fri, May 29, 2015 at 12:37 AM, Vivien Didelot wrote: > @@ -854,7 +922,9 @@ int dsa_slave_create(struct dsa_switch *ds, struct device > *parent, > if (slave_dev == NULL) > return -ENOMEM; > > - slave_dev->features = master->vlan_features; > + slave_dev->featu

Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-28 Thread Scott Feldman
On Thu, May 28, 2015 at 2:37 PM, Vivien Didelot wrote: > This patch adds the ndo_vlan_rx_add_vid, ndo_vlan_rx_kill_vid, and > ndo_bridge_setlink wrapper operations, used to create and remove VLAN > entries in a DSA switch VLAN database. > > The switch drivers have to implement the port_vlan_add, p

[RFC 1/3] net: dsa: add basic support for VLAN ndo

2015-05-28 Thread Vivien Didelot
This patch adds the ndo_vlan_rx_add_vid, ndo_vlan_rx_kill_vid, and ndo_bridge_setlink wrapper operations, used to create and remove VLAN entries in a DSA switch VLAN database. The switch drivers have to implement the port_vlan_add, port_vlan_kill, and port_bridge_setlink functions, in order to sup