Re: [RFC 1/2] bridge: avoid ptype_all packet handling

2007-03-02 Thread Herbert Xu
On Fri, Mar 02, 2007 at 09:59:05PM -0800, David Miller wrote: > > So it's still a mystery why dhcp is causing bridge devices > to trigger the network tap paths on Stephen's machine. If this is the ISC DHCP daemon then perhaps it's because Stephen didn't specify an interface for it to listen on? B

Re: [RFC 1/2] bridge: avoid ptype_all packet handling

2007-03-02 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 03 Mar 2007 16:38:45 +1100 > This is using packet_bind_spkt which uses a name instead of ifindex. So it should be just fine, it should be binding to a specific device (by name instead of ifindex) and therefore it should only trigger the pt_all hook

Re: [RFC 1/2] bridge: avoid ptype_all packet handling

2007-03-02 Thread Herbert Xu
David Miller <[EMAIL PROTECTED]> wrote: > > I'm tempted to say I must be missing something here, since I can't see > how this could possible work at all. The string passed in should > be interpreted as the ifindex value, and thus trigger a -ENODEV > return from AF_PACKET's bind() implementation.

Re: [RFC 1/2] bridge: avoid ptype_all packet handling

2007-03-02 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 2 Mar 2007 15:34:14 -0800 > Can you get FC fixed? I am not the DHCP package maintainer. :-) I'm up to my earfulls already dealing with people trying to slug broken patches into the kernel networking that paper around application bugs. ;) >

Re: [RFC 1/2] bridge: avoid ptype_all packet handling

2007-03-02 Thread Stephen Hemminger
On Fri, 02 Mar 2007 15:18:03 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Fri, 02 Mar 2007 14:48:18 -0800 (PST) > > > Back to a workable solution, why doesn't DHCP specify a specific > > device? It would fix this performance problem complet

Re: [RFC 1/2] bridge: avoid ptype_all packet handling

2007-03-02 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Fri, 02 Mar 2007 14:48:18 -0800 (PST) > Back to a workable solution, why doesn't DHCP specify a specific > device? It would fix this performance problem completely, at the > application level. Since nobody seems to be able to be bothered to actually l

Re: [RFC 1/2] bridge: avoid ptype_all packet handling

2007-03-02 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 2 Mar 2007 14:09:29 -0800 > On Fri, 02 Mar 2007 13:26:38 -0800 (PST) > David Miller <[EMAIL PROTECTED]> wrote: > > > From: Stephen Hemminger <[EMAIL PROTECTED]> > > Date: Wed, 28 Feb 2007 17:18:46 -0800 > > > > > I was measuring bridging/rou

[RFC 1/2] bridge: avoid ptype_all packet handling

2007-03-02 Thread Stephen Hemminger
On Fri, 02 Mar 2007 13:26:38 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Wed, 28 Feb 2007 17:18:46 -0800 > > > I was measuring bridging/routing performance and noticed this. > > > > The current code runs the "all packet" type handlers

[RFC 1/2] bridge: avoid ptype_all packet handling

2007-03-02 Thread Stephen Hemminger
On Fri, 02 Mar 2007 13:26:38 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Wed, 28 Feb 2007 17:18:46 -0800 > > > I was measuring bridging/routing performance and noticed this. > > > > The current code runs the "all packet" type handlers