Re: [RFC 1/2] bpf: move instruction printing into a separate file

2017-10-03 Thread Alexei Starovoitov
On Tue, Oct 03, 2017 at 10:57:45AM -0700, Jakub Kicinski wrote: > Separate the instruction printing into a standalone source file. > This way sneaky code from tools/ can use it directly. > > Signed-off-by: Jakub Kicinski > --- > Like this? ... > +static void print_bpf_end_insn(void (*verbose)(con

Re: [RFC 1/2] bpf: move instruction printing into a separate file

2017-10-03 Thread Daniel Borkmann
On 10/03/2017 07:57 PM, Jakub Kicinski wrote: Separate the instruction printing into a standalone source file. This way sneaky code from tools/ can use it directly. Signed-off-by: Jakub Kicinski --- Like this? Looks good to me, yes.

[RFC 1/2] bpf: move instruction printing into a separate file

2017-10-03 Thread Jakub Kicinski
Separate the instruction printing into a standalone source file. This way sneaky code from tools/ can use it directly. Signed-off-by: Jakub Kicinski --- Like this? kernel/bpf/Makefile | 1 + kernel/bpf/disasm.c | 212 ++ kernel/bpf/disasm.h