Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-10-05 Thread Jason Gunthorpe
On Fri, Oct 04, 2019 at 05:46:15PM -0700, Jeff Kirsher wrote: > On Fri, 2019-10-04 at 23:45 +, Jason Gunthorpe wrote: > > On Fri, Oct 04, 2019 at 01:12:22PM -0700, Jeff Kirsher wrote: > > > > > > > + if (ldev->version.major != I40E_CLIENT_VERSION_MAJOR || > > > > > + ldev->version.

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-10-05 Thread gre...@linuxfoundation.org
On Sat, Oct 05, 2019 at 09:28:05AM +0300, Leon Romanovsky wrote: > On Fri, Oct 04, 2019 at 05:46:15PM -0700, Jeff Kirsher wrote: > > On Fri, 2019-10-04 at 23:45 +, Jason Gunthorpe wrote: > > > On Fri, Oct 04, 2019 at 01:12:22PM -0700, Jeff Kirsher wrote: > > > > > > > > > + if (ldev->version.

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-10-04 Thread Leon Romanovsky
On Fri, Oct 04, 2019 at 05:46:15PM -0700, Jeff Kirsher wrote: > On Fri, 2019-10-04 at 23:45 +, Jason Gunthorpe wrote: > > On Fri, Oct 04, 2019 at 01:12:22PM -0700, Jeff Kirsher wrote: > > > > > > > + if (ldev->version.major != I40E_CLIENT_VERSION_MAJOR || > > > > > + ldev->version.m

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-10-04 Thread Jeff Kirsher
On Fri, 2019-10-04 at 23:45 +, Jason Gunthorpe wrote: > On Fri, Oct 04, 2019 at 01:12:22PM -0700, Jeff Kirsher wrote: > > > > > + if (ldev->version.major != I40E_CLIENT_VERSION_MAJOR || > > > > + ldev->version.minor != I40E_CLIENT_VERSION_MINOR) { > > > > + pr_err

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-10-04 Thread Jason Gunthorpe
On Fri, Oct 04, 2019 at 01:12:22PM -0700, Jeff Kirsher wrote: > > > + if (ldev->version.major != I40E_CLIENT_VERSION_MAJOR || > > > + ldev->version.minor != I40E_CLIENT_VERSION_MINOR) { > > > + pr_err("version mismatch:\n"); > > > + pr_err("expected major ver %d, caller specifi

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-10-04 Thread Jeff Kirsher
On Thu, 2019-09-26 at 20:30 +0300, Leon Romanovsky wrote: > On Thu, Sep 26, 2019 at 09:45:03AM -0700, Jeff Kirsher wrote: > > From: Mustafa Ismail > > > > Register irdma as a platform driver capable of supporting platform > > devices from multi-generation RDMA capable Intel HW. Establish the > >

RE: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread Saleem, Shiraz
> Subject: Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions > <...> > > +/** > > + * i40iw_l2param_change - handle qs handles for QoS and MSS change > > + * @ldev: LAN device information > > + * @client: client for parameter change >

RE: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread Saleem, Shiraz
> Subject: Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions > > On Thu, Sep 26, 2019 at 08:02:15PM +0200, gre...@linuxfoundation.org wrote: > > On Thu, Sep 26, 2019 at 04:55:12PM +, Jason Gunthorpe wrote: > > > On Thu, Sep 26, 2019 at 09:45:03AM -

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread Jason Gunthorpe
On Thu, Sep 26, 2019 at 08:02:15PM +0200, gre...@linuxfoundation.org wrote: > On Thu, Sep 26, 2019 at 04:55:12PM +, Jason Gunthorpe wrote: > > On Thu, Sep 26, 2019 at 09:45:03AM -0700, Jeff Kirsher wrote: > > > +int i40iw_probe(struct platform_device *pdev) > > > +{ > > > + struct i40e_peer_dev

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread gre...@linuxfoundation.org
On Thu, Sep 26, 2019 at 04:55:12PM +, Jason Gunthorpe wrote: > On Thu, Sep 26, 2019 at 09:45:03AM -0700, Jeff Kirsher wrote: > > +int i40iw_probe(struct platform_device *pdev) > > +{ > > + struct i40e_peer_dev_platform_data *pdata = > > + dev_get_platdata(&pdev->dev); > > + struct

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread Leon Romanovsky
On Thu, Sep 26, 2019 at 09:45:03AM -0700, Jeff Kirsher wrote: > From: Mustafa Ismail > > Register irdma as a platform driver capable of supporting platform > devices from multi-generation RDMA capable Intel HW. Establish the > interface with all supported netdev peer devices and initialize HW. > >

Re: [RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread Jason Gunthorpe
On Thu, Sep 26, 2019 at 09:45:03AM -0700, Jeff Kirsher wrote: > +int i40iw_probe(struct platform_device *pdev) > +{ > + struct i40e_peer_dev_platform_data *pdata = > + dev_get_platdata(&pdev->dev); > + struct i40e_info *ldev; I thought Greg already said not to use platform_devi

[RFC 04/20] RDMA/irdma: Add driver framework definitions

2019-09-26 Thread Jeff Kirsher
From: Mustafa Ismail Register irdma as a platform driver capable of supporting platform devices from multi-generation RDMA capable Intel HW. Establish the interface with all supported netdev peer devices and initialize HW. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem Signed-off-b