RE: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-14 Thread Amrani, Ram
> > What do you mean by "standard kernel names"? > > By that I mean 'identical copies' do not copy the file and then randomly > change > it giving things different names or putting different content in structs. > > You will want to submit your user provider to rdma-plumbing to get it into the >

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-14 Thread Jason Gunthorpe
On Wed, Sep 14, 2016 at 02:44:47PM +, Amrani, Ram wrote: > > Anything that is used with copy_to/from_user, ib_copy_to/from_udata, > > etc, etc must be in a include/uapi header. > > > > Any constant you might want to copy into your userspace provider must > > be in include/uapi. > > > I unde

RE: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-14 Thread Amrani, Ram
> Anything that is used with copy_to/from_user, ib_copy_to/from_udata, > etc, etc must be in a include/uapi header. > > Any constant you might want to copy into your userspace provider must > be in include/uapi. > I understand you mean something like https://www.spinics.net/lists/linux-rdma/ms

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-14 Thread Sagi Grimberg
> SRQ is not part of the RFC (but we do have it and NVMF was tested with it). Nice, I have plans to make SRQs better usable for our ULPs so it'd be good to have it. That’s good to know. Are there plans on implementing XRC? Right now it looks like none of the ULPS make use of it. The

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-13 Thread Jason Gunthorpe
On Tue, Sep 13, 2016 at 08:44:06AM +, Ram Amrani wrote: > Hi Jason, > I see that "include/uapi/rdma" contains API that is common. It is intended to contain *all* the uapi. > The qedr_user.h, that I assume you are referring to, is a qedr specific API. > For example, we issue the ib_copy_to_uda

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-13 Thread Sagi Grimberg
Hey Ram and Co, This series introduces RoCE RDMA driver for the 579xx RDMA products by Qlogic. The RDMA support is added as an additional loadable module (qedr) over the Ethernet qede driver. The qedr module will support both RoCE and iWarp, although this series only adds RoCE support. The qed

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-13 Thread Leon Romanovsky
On Tue, Sep 13, 2016 at 06:48:00AM +, Mintz, Yuval wrote: > >> While this might work, I personally dislike it as I find it > >> counter-intuitive when going over the code - > >> I don't expect driver to locally modify the inclusion path. > >> Besides, we're going to [eventually] a whole suite o

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-13 Thread Leon Romanovsky
e- > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Monday, September 12, 2016 9:05 PM > To: Ram Amrani > Cc: dledf...@redhat.com; David Miller ; Yuval Mintz > ; Ariel Elior ; Michal > Kalderon ; Rajesh Borundia > ; linux-r...@vger.kernel.org; netdev >

RE: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-13 Thread Ram Amrani
[RFC 00/11] QLogic RDMA Driver (qedr) RFC On Mon, Sep 12, 2016 at 07:07:34PM +0300, Ram Amrani wrote: > drivers/infiniband/hw/qedr/main.c | 907 ++ > drivers/infiniband/hw/qedr/qedr.h | 494 > drivers/infiniband/hw/qedr/qedr_cm.c | 6

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-13 Thread Mintz, Yuval
>> While this might work, I personally dislike it as I find it >> counter-intuitive when going over the code - >> I don't expect driver to locally modify the inclusion path. >> Besides, we're going to [eventually] a whole suite of drivers based >> on the qed module, some of which would reside under

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-12 Thread Leon Romanovsky
On Mon, Sep 12, 2016 at 05:39:35PM +, Yuval Mintz wrote: > >>>  include/linux/qed/common_hsi.h |    1 + > >>>  include/linux/qed/qed_if.h |    9 +- > >>>  include/linux/qed/qed_ll2_if.h |  140 + > >>>  include/linux/qed/qed_roce_if.h  

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-12 Thread Jason Gunthorpe
On Mon, Sep 12, 2016 at 07:07:34PM +0300, Ram Amrani wrote: > drivers/infiniband/hw/qedr/main.c | 907 ++ > drivers/infiniband/hw/qedr/qedr.h | 494 > drivers/infiniband/hw/qedr/qedr_cm.c | 626 + > drivers/infiniband/hw/qedr/qedr_cm.h

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-12 Thread Yuval Mintz
>>>  include/linux/qed/common_hsi.h |    1 + >>>  include/linux/qed/qed_if.h |    9 +- >>>  include/linux/qed/qed_ll2_if.h |  140 + >>>  include/linux/qed/qed_roce_if.h    |  604 >>>  include/linux/qed/qede_roce.h 

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-12 Thread Parav Pandit
On Mon, Sep 12, 2016 at 10:09 PM, Leon Romanovsky wrote: > On Mon, Sep 12, 2016 at 07:07:34PM +0300, Ram Amrani wrote: > >> include/linux/qed/common_hsi.h |1 + >> include/linux/qed/qed_if.h |9 +- >> include/linux/qed/qed_ll2_if.h | 14

Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-12 Thread Leon Romanovsky
On Mon, Sep 12, 2016 at 07:07:34PM +0300, Ram Amrani wrote: > include/linux/qed/common_hsi.h |1 + > include/linux/qed/qed_if.h |9 +- > include/linux/qed/qed_ll2_if.h | 140 + > include/linux/qed/qed_roce_if.h| 604 +++

[RFC 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-12 Thread Ram Amrani
This series introduces RoCE RDMA driver for the 579xx RDMA products by Qlogic. The RDMA support is added as an additional loadable module (qedr) over the Ethernet qede driver. The qedr module will support both RoCE and iWarp, although this series only adds RoCE support. The qed and qede drivers a