Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-29 Thread Lukasz Majewski
Hi Florian, > On 11/27/2020 4:33 PM, Lukasz Majewski wrote: > >> So why use DSA at all? What benefit does it bring you? Why not do > >> the entire switch configuration from within FEC, or a separate > >> driver very closely related to it? > > > > Mine rationale to use DSA and FEC: > > - Make as

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-28 Thread Florian Fainelli
On 11/27/2020 4:33 PM, Lukasz Majewski wrote: >> So why use DSA at all? What benefit does it bring you? Why not do the >> entire switch configuration from within FEC, or a separate driver very >> closely related to it? > > Mine rationale to use DSA and FEC: > - Make as little changes to FEC as

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-27 Thread Lukasz Majewski
Hi Vladimir, > On Fri, Nov 27, 2020 at 12:35:49AM +0100, Lukasz Majewski wrote: > > > > - The question regarding power management - at least for my use > > > > case there is no need for runtime power management. The L2 > > > > switch shall work always at it connects other devices. > > > > > > > >

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-27 Thread Vladimir Oltean
On Fri, Nov 27, 2020 at 12:35:49AM +0100, Lukasz Majewski wrote: > > > - The question regarding power management - at least for my use > > > case there is no need for runtime power management. The L2 switch > > > shall work always at it connects other devices. > > > > > > - The FEC clock is also us

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-27 Thread Andrew Lunn
On Fri, Nov 27, 2020 at 10:25:28AM +0100, Lukasz Majewski wrote: > Hi Andrew, > > > > > I would push back and say that the switch offers bridge > > > > acceleration for the FEC. > > > > > > Am I correct, that the "bridge acceleration" means in-hardware > > > support for L2 packet bridging?

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-27 Thread Lukasz Majewski
Hi Andrew, > > > I would push back and say that the switch offers bridge > > > acceleration for the FEC. > > > > Am I correct, that the "bridge acceleration" means in-hardware > > support for L2 packet bridging? > > You should think of the hardware as an accelerator, not a switch. The > ha

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-27 Thread Lukasz Majewski
Hi Andrew, > > (A side question - DSA uses switchdev, so when one shall use > > switchdev standalone?) > > DSA gives you a framework for an Ethernet switch connected to a host > via Ethernet for the data plane. Generally, that Ethernet link to the > switch is a MAC to MAC connection. It can be

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-26 Thread Andrew Lunn
> > I would push back and say that the switch offers bridge acceleration > > for the FEC. > > Am I correct, that the "bridge acceleration" means in-hardware support > for L2 packet bridging? You should think of the hardware as an accelerator, not a switch. The hardware is there to accelerate wh

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-26 Thread Andrew Lunn
> (A side question - DSA uses switchdev, so when one shall use switchdev > standalone?) DSA gives you a framework for an Ethernet switch connected to a host via Ethernet for the data plane. Generally, that Ethernet link to the switch is a MAC to MAC connection. It can be PHY to PHY. But those are

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-26 Thread Lukasz Majewski
Hi Andrew, > > > What is not yet clear to me is how you direct frames out specific > > > interfaces. This is where i think we hit problems. I don't see a > > > generic mechanism, which is probably why Lukasz put tagger as > > > None. > > > > I've put the "None" tag just to share the "testable"

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-26 Thread Lukasz Majewski
Hi Vladimir, > Hi Lukasz, > > On Thu, Nov 26, 2020 at 12:24:55AM +0100, Lukasz Majewski wrote: > > This is the first attempt to add support for L2 switch available on > > some NXP devices - i.e. iMX287 or VF610. This patch set uses common > > FEC and DSA code. > > > > This code provides _very_ ba

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-26 Thread Andrew Lunn
> > What is not yet clear to me is how you direct frames out specific > > interfaces. This is where i think we hit problems. I don't see a > > generic mechanism, which is probably why Lukasz put tagger as None. > > I've put the "None" tag just to share the "testable" RFC code. Tagging is a core

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-26 Thread Vladimir Oltean
Hi Lukasz, On Thu, Nov 26, 2020 at 12:24:55AM +0100, Lukasz Majewski wrote: > This is the first attempt to add support for L2 switch available on some NXP > devices - i.e. iMX287 or VF610. This patch set uses common FEC and DSA code. > > This code provides _very_ basic switch functionality (packet

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-26 Thread Lukasz Majewski
Hi Andrew, Florian, > On Wed, Nov 25, 2020 at 05:30:04PM -0800, Florian Fainelli wrote: > > > > > > On 11/25/2020 4:00 PM, Andrew Lunn wrote: > > > On Thu, Nov 26, 2020 at 12:24:55AM +0100, Lukasz Majewski wrote: > > >> This is the first attempt to add support for L2 switch available > > >>

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-25 Thread Andrew Lunn
On Wed, Nov 25, 2020 at 05:30:04PM -0800, Florian Fainelli wrote: > > > On 11/25/2020 4:00 PM, Andrew Lunn wrote: > > On Thu, Nov 26, 2020 at 12:24:55AM +0100, Lukasz Majewski wrote: > >> This is the first attempt to add support for L2 switch available on some > >> NXP > >> devices - i.e. iMX287

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-25 Thread Florian Fainelli
On 11/25/2020 4:00 PM, Andrew Lunn wrote: > On Thu, Nov 26, 2020 at 12:24:55AM +0100, Lukasz Majewski wrote: >> This is the first attempt to add support for L2 switch available on some NXP >> devices - i.e. iMX287 or VF610. This patch set uses common FEC and DSA code. > > Interesting. I need to

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-25 Thread Andrew Lunn
On Thu, Nov 26, 2020 at 12:24:55AM +0100, Lukasz Majewski wrote: > This is the first attempt to add support for L2 switch available on some NXP > devices - i.e. iMX287 or VF610. This patch set uses common FEC and DSA code. Interesting. I need to take another look at the Vybrid manual. Last time i

[RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-25 Thread Lukasz Majewski
This is the first attempt to add support for L2 switch available on some NXP devices - i.e. iMX287 or VF610. This patch set uses common FEC and DSA code. This code provides _very_ basic switch functionality (packets are passed between lan1 and lan2 ports and it is possible to send packets via eth0