Re: [kernel-hardening] Re: [RFC 0/3] kallsyms: don't leak address when printing symbol

2017-11-29 Thread Tobin C. Harding
On Tue, Nov 28, 2017 at 08:58:44AM +0530, Kaiwan N Billimoria wrote: > On Tue, Nov 28, 2017 at 7:20 AM, Tobin C. Harding wrote: > > > > Noob question: how do we _know_ this. In other words how do we know no > > userland tools rely on the current behaviour? No stress to answer Kees, > > this is a p

Re: [kernel-hardening] Re: [RFC 0/3] kallsyms: don't leak address when printing symbol

2017-11-27 Thread Kaiwan N Billimoria
On Tue, Nov 28, 2017 at 7:20 AM, Tobin C. Harding wrote: > > Noob question: how do we _know_ this. In other words how do we know no > userland tools rely on the current behaviour? No stress to answer Kees, > this is a pretty general kernel dev question. Perhaps I'm reading this wrong, but anyway:

Re: [RFC 0/3] kallsyms: don't leak address when printing symbol

2017-11-27 Thread Tobin C. Harding
On Mon, Nov 27, 2017 at 04:52:21PM -0800, Kees Cook wrote: > On Mon, Nov 27, 2017 at 2:30 PM, Tobin C. Harding wrote: > > This is an RFC for two reasons. > > > > 1) I don't know who this patch set may break? > > 2) Patch set includes a function that is not called. Function is there > >to facil

Re: [RFC 0/3] kallsyms: don't leak address when printing symbol

2017-11-27 Thread Kees Cook
On Mon, Nov 27, 2017 at 2:30 PM, Tobin C. Harding wrote: > This is an RFC for two reasons. > > 1) I don't know who this patch set may break? > 2) Patch set includes a function that is not called. Function is there >to facilitate fixing breakages. > > _If_ no one gets broken then we can remove

[RFC 0/3] kallsyms: don't leak address when printing symbol

2017-11-27 Thread Tobin C. Harding
This is an RFC for two reasons. 1) I don't know who this patch set may break? 2) Patch set includes a function that is not called. Function is there to facilitate fixing breakages. _If_ no one gets broken then we can remove the unused function. Thanks for looking at this. Currently if a poin