Re: [RFC -next v0 1/3] bpf: modular maps

2018-12-10 Thread Aaron Conole
Alexei Starovoitov writes: > On Fri, Nov 30, 2018 at 08:49:17AM -0500, Aaron Conole wrote: >> >> While this is one reason to use hash map, I don't think we should use >> this as a reason to exclude development of a data type that may work >> better. After all, if we can do better then we should

Re: [RFC -next v0 1/3] bpf: modular maps

2018-12-04 Thread Alexei Starovoitov
On Fri, Nov 30, 2018 at 08:49:17AM -0500, Aaron Conole wrote: > > While this is one reason to use hash map, I don't think we should use > this as a reason to exclude development of a data type that may work > better. After all, if we can do better then we should. I'm all for improving existing h

Re: [RFC -next v0 1/3] bpf: modular maps

2018-11-30 Thread Aaron Conole
Alexei Starovoitov writes: > On Wed, Nov 28, 2018 at 01:51:42PM -0500, Aaron Conole wrote: >> Alexei Starovoitov writes: >> >> > On Tue, Nov 27, 2018 at 09:24:05AM -0500, Aaron Conole wrote: >> >> >> >> 1. Introduce flowmap again, this time, basically having it close to a >> >> copy of

Re: [RFC -next v0 1/3] bpf: modular maps

2018-11-28 Thread Alexei Starovoitov
On Wed, Nov 28, 2018 at 01:51:42PM -0500, Aaron Conole wrote: > Alexei Starovoitov writes: > > > On Tue, Nov 27, 2018 at 09:24:05AM -0500, Aaron Conole wrote: > >> > >> 1. Introduce flowmap again, this time, basically having it close to a > >> copy of the hashmap. Introduce a few functio

Re: [RFC -next v0 1/3] bpf: modular maps

2018-11-28 Thread Aaron Conole
Alexei Starovoitov writes: > On Tue, Nov 27, 2018 at 09:24:05AM -0500, Aaron Conole wrote: >> >> 1. Introduce flowmap again, this time, basically having it close to a >> copy of the hashmap. Introduce a few function calls that allow an >> external module to easily manipulate all map

Re: [RFC -next v0 1/3] bpf: modular maps

2018-11-27 Thread Alexei Starovoitov
On Tue, Nov 27, 2018 at 09:24:05AM -0500, Aaron Conole wrote: > > 1. Introduce flowmap again, this time, basically having it close to a > copy of the hashmap. Introduce a few function calls that allow an > external module to easily manipulate all maps of that type to insert > / r

Re: [RFC -next v0 1/3] bpf: modular maps

2018-11-27 Thread Aaron Conole
Alexei Starovoitov writes: > On Sun, Nov 25, 2018 at 01:09:17PM -0500, Aaron Conole wrote: >> This commit allows for map operations to be loaded by an lkm, rather than >> needing to be baked into the kernel at compile time. > > Nack. > Please see Documentation/bpf/bpf_design_QA.rst Thanks for th

Re: [RFC -next v0 1/3] bpf: modular maps

2018-11-26 Thread Alexei Starovoitov
On Sun, Nov 25, 2018 at 01:09:17PM -0500, Aaron Conole wrote: > This commit allows for map operations to be loaded by an lkm, rather than > needing to be baked into the kernel at compile time. Nack. Please see Documentation/bpf/bpf_design_QA.rst

[RFC -next v0 1/3] bpf: modular maps

2018-11-25 Thread Aaron Conole
This commit allows for map operations to be loaded by an lkm, rather than needing to be baked into the kernel at compile time. Signed-off-by: Aaron Conole --- include/linux/bpf.h | 6 + init/Kconfig | 8 +++ kernel/bpf/syscall.c | 57 +++