Re: [RFC -next 2/2] net: sched: red: don't reset the backlog on every stat dump

2018-01-08 Thread Jakub Kicinski
On Mon, 8 Jan 2018 09:18:08 +, Nogah Frankel wrote: > > Unlike for other statistics new_hw_stat < prev_hw_stat can be true. > > Adjust mlxsw. > > There is one problem with this patch, and that is that we can fail in > changing RED that is offloaded. In this case, we delete RED from the driv

RE: [RFC -next 2/2] net: sched: red: don't reset the backlog on every stat dump

2018-01-08 Thread Nogah Frankel
driv...@netronome.com; > eduma...@google.com; Jakub Kicinski > Subject: [RFC -next 2/2] net: sched: red: don't reset the backlog on every > stat > dump > > Commit 0dfb33a0d7e2 ("sch_red: report backlog information") copied > child's backlog into RED'

[RFC -next 2/2] net: sched: red: don't reset the backlog on every stat dump

2018-01-04 Thread Jakub Kicinski
Commit 0dfb33a0d7e2 ("sch_red: report backlog information") copied child's backlog into RED's backlog. Back then RED did not maintain its own backlog counts. This has changed after commit 2f5fb43f ("net_sched: update hierarchical backlog too") and commit d7f4f332f082 ("sch_red: update backlog