Re: [RFC] split NAPI from network device.

2007-02-22 Thread Divy Le Ray
Hi Dave, @@ -919,10 +920,7 @@ int dev_close(struct net_device *dev) * engine, but this requires more changes in devices. */ smp_mb__after_clear_bit(); /* Commit netif_running(). */ - while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) { - /* No hurry. */ -

Re: [RFC] split NAPI from network device.

2007-02-22 Thread David Miller
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Date: Thu, 22 Feb 2007 10:24:31 +1100 > The device has a single interrupt though that interrupt at least can > tell you which queues need servicing. It can't mask the interrupt per > queue though, which is the main issue. Right, which effectively t

Re: [RFC] split NAPI from network device.

2007-02-21 Thread Benjamin Herrenschmidt
> Actually, Ben did you determine if this scheme works for your device > which has a single interrupt source yet multiple queues? There is one > driver that, during the conversion, I noticed has a similar issue. > One driver, netxen, has multiple channels, so it just passes in > "bugdet / NUM_CHA

Re: [RFC] split NAPI from network device.

2007-02-20 Thread David Miller
From: Divy Le Ray <[EMAIL PROTECTED]> Date: Tue, 20 Feb 2007 23:39:55 -0800 > I applied the patch to test the chelsio drivers. > The compilation of the forcedeth driver fails if CONFIG_FORCEDETH_NAPI > is not set. > /opt/sources/linux-2.6/drivers/net/forcedeth.c: In function `nv_nic_irq': > /opt/

Re: [RFC] split NAPI from network device.

2007-02-20 Thread Divy Le Ray
David Miller wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 13 Dec 2006 15:46:35 -0800 Split off NAPI part from network device, this patch is build tested only! It breaks kernel API for network devices, and only three examples are fixed (skge, sky2, and tg3). 1. Decomposition

Re: [RFC] split NAPI from network device.

2006-12-14 Thread Benjamin Herrenschmidt
On Wed, 2006-12-13 at 15:46 -0800, Stephen Hemminger wrote: > Split off NAPI part from network device, this patch is build tested > only! It breaks kernel API for network devices, and only three examples > are fixed (skge, sky2, and tg3). > > 1. Decomposition allows different NAPI <-> network devi

[RFC] split NAPI from network device.

2006-12-13 Thread Stephen Hemminger
Split off NAPI part from network device, this patch is build tested only! It breaks kernel API for network devices, and only three examples are fixed (skge, sky2, and tg3). 1. Decomposition allows different NAPI <-> network device Some hardware has N devices for one IRQ, others like MSI-X wa