Re: [RFC] potential bugs in nexten

2007-12-24 Thread Dhananjay Phadke
Probably I need to clean up much more junk like that from days before I took over. I recently cleaned up a bit of rx and tx code, which is more frequently executed. The last one (byte swapping) is serious and I am gonna take care of that in next patch. Thanks, -Dhananjay On Sun, 23 Dec 2007,

[RFC] potential bugs in nexten

2007-12-23 Thread Al Viro
* what are default: doing in netxen_nic_hw_write_wx()/netxen_nic_hw_read_wx()? Unlike all other cases they do iomem->iomem copying and AFAICS they are never actually triggered. * netxen_nic_flash_print() reads the entire user_info from card *in* *host-endian*, then uses user_info.serial_number[]