Re: [RFC] new qla3xxx NIC Driver v2.02.00b01

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 10:58:44 -0800 "Ron Mercer" <[EMAIL PROTECTED]> wrote: > > * Use existing MII code and interface > > Do you mean support for the get/set IOCTLS SIOCGMIIREG/SIOCSMIIREG? > > > If you can look at using mii.c and include/linux/mii.h. Not all drivers can, and the interface is

RE: [RFC] new qla3xxx NIC Driver v2.02.00b01

2006-03-24 Thread Ron Mercer
> * Use existing MII code and interface Do you mean support for the get/set IOCTLS SIOCGMIIREG/SIOCSMIIREG? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] new qla3xxx NIC Driver v2.02.00b01

2006-03-20 Thread Stephen Hemminger
On Mon, 20 Mar 2006 11:07:34 -0800 "Ron Mercer" <[EMAIL PROTECTED]> wrote: > Stephen, > > Thank you for taking the time to review my driver. The feedback was > great. I will endeavor to bring it up to an A+. Please see my comments > below. > > > * Do nvram via ethtool > I am not sure what yo

RE: [RFC] new qla3xxx NIC Driver v2.02.00b01

2006-03-20 Thread Ron Mercer
: Ron Mercer > Cc: netdev@vger.kernel.org; Linux Driver > Subject: Re: [RFC] new qla3xxx NIC Driver v2.02.00b01 > > Overall, if this were a class assignment I would give it a C- if I was > feeling generous. It tries to follow the linux driver style, but it > really needs more work

Re: [RFC] new qla3xxx NIC Driver v2.02.00b01

2006-03-17 Thread Stephen Hemminger
Overall, if this were a class assignment I would give it a C- if I was feeling generous. It tries to follow the linux driver style, but it really needs more work and is incomplete at this time. * The most troublesome design flaw seems to be that the hardware knows about the ip_address. Well, if

[RFC] new qla3xxx NIC Driver v2.02.00b01

2006-03-16 Thread Ron Mercer
All, Request for comments for the upstream inclusion of the qla3xxx driver. This is a complementary network driver for our ISP4XXX parts. There is a concurrent effort underway to get the iSCSI driver (qla4xxx) integrated upstream as well. The following files are included and have been posted to