Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-10 Thread Sven Wegener
On Sat, 9 Feb 2008, Christoph Hellwig wrote: On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote: struct ip_vs_sync_thread_data { - struct completion *startup; + struct completion *startup; /* set to NULL once completed */ This is not needed anmore. kthread_run guarante

Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote: > struct ip_vs_sync_thread_data { > - struct completion *startup; > + struct completion *startup; /* set to NULL once completed */ This is not needed anmore. kthread_run guarantees that the newly creates thread is run before r

Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Simon Horman
On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote: > Hi all, > > I'd like to get your feedback on this: > > - Use kthread_run instead of doing a double-fork via kernel_thread() > > - Return proper error codes to user-space on failures > > Currently ipvsadm --start-daemon with an invalid

[RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Sven Wegener
Hi all, I'd like to get your feedback on this: - Use kthread_run instead of doing a double-fork via kernel_thread() - Return proper error codes to user-space on failures Currently ipvsadm --start-daemon with an invalid --mcast-interface will silently suceed. With these changes we get an appro