Re: [RFC] bonding driver terminology change proposal

2020-08-12 Thread Jarod Wilson
On Thu, Jul 16, 2020 at 1:43 AM Jarod Wilson wrote: > > On Wed, Jul 15, 2020 at 11:18 PM Andrew Lunn wrote: ... > > I really think that before we consider changes like this, somebody > > needs to work on git tooling, so that it knows when mass renames have > > happened, and can do the same sort o

Re: [RFC] bonding driver terminology change proposal

2020-07-16 Thread Stephen Hemminger
On Thu, 16 Jul 2020 11:59:47 -0700 (PDT) David Miller wrote: > From: Jarod Wilson > Date: Wed, 15 Jul 2020 23:06:55 -0400 > > > On Mon, Jul 13, 2020 at 9:00 PM David Miller wrote: > >> > >> From: Michal Kubecek > >> Date: Tue, 14 Jul 2020 00:00:16 +0200 > >> > >> > Could we, please, avoid

Re: [RFC] bonding driver terminology change proposal

2020-07-16 Thread David Miller
From: Jarod Wilson Date: Wed, 15 Jul 2020 23:06:55 -0400 > On Mon, Jul 13, 2020 at 9:00 PM David Miller wrote: >> >> From: Michal Kubecek >> Date: Tue, 14 Jul 2020 00:00:16 +0200 >> >> > Could we, please, avoid breaking existing userspace tools and scripts? >> >> I will not let UAPI breakage, d

Re: [RFC] bonding driver terminology change proposal

2020-07-15 Thread Jarod Wilson
On Wed, Jul 15, 2020 at 11:18 PM Andrew Lunn wrote: > > On Wed, Jul 15, 2020 at 11:04:16PM -0400, Jarod Wilson wrote: > > On Mon, Jul 13, 2020 at 8:26 PM Andrew Lunn wrote: > > > > > > Hi Jarod > > > > > > Do you have this change scripted? Could you apply the script to v5.4 > > > and then cherry-

Re: [RFC] bonding driver terminology change proposal

2020-07-15 Thread Andrew Lunn
On Wed, Jul 15, 2020 at 11:04:16PM -0400, Jarod Wilson wrote: > On Mon, Jul 13, 2020 at 8:26 PM Andrew Lunn wrote: > > > > Hi Jarod > > > > Do you have this change scripted? Could you apply the script to v5.4 > > and then cherry-pick the 8 bonding fixes that exist in v5.4.51. How > > many result i

Re: [RFC] bonding driver terminology change proposal

2020-07-15 Thread Jarod Wilson
On Mon, Jul 13, 2020 at 9:00 PM David Miller wrote: > > From: Michal Kubecek > Date: Tue, 14 Jul 2020 00:00:16 +0200 > > > Could we, please, avoid breaking existing userspace tools and scripts? > > I will not let UAPI breakage, don't worry. Seeking some clarification here. Does the output of /pr

Re: [RFC] bonding driver terminology change proposal

2020-07-15 Thread Jarod Wilson
On Mon, Jul 13, 2020 at 8:26 PM Andrew Lunn wrote: > > Hi Jarod > > Do you have this change scripted? Could you apply the script to v5.4 > and then cherry-pick the 8 bonding fixes that exist in v5.4.51. How > many result in conflicts? > > Could you do the same with v4.19...v4.19.132, which has 20

Re: [RFC] bonding driver terminology change proposal

2020-07-15 Thread Jarod Wilson
On Wed, Jul 15, 2020 at 8:57 AM Edward Cree wrote: > > Once again, the opinions below are my own and definitely do not > represent anything my employer would be seen dead in the same > room as. > > On 13/07/2020 23:41, Stephen Hemminger wrote: > > As far as userspace, maybe keep the old API's bu

Re: [RFC] bonding driver terminology change proposal

2020-07-15 Thread Edward Cree
Once again, the opinions below are my own and definitely do not  represent anything my employer would be seen dead in the same  room as. On 13/07/2020 23:41, Stephen Hemminger wrote: > As far as userspace, maybe keep the old API's but provide deprecation nags. Why would you need to deprecate the o

Re: [RFC] bonding driver terminology change proposal

2020-07-14 Thread Jarod Wilson
On Tue, Jul 14, 2020 at 4:39 PM Marcelo Ricardo Leitner wrote: > > On Tue, Jul 14, 2020 at 09:17:48PM +0200, Toke Høiland-Jørgensen wrote: > > Jarod Wilson writes: > > > > > As part of an effort to help enact social change, Red Hat is > > > committing to efforts to eliminate any problematic ter

Re: [RFC] bonding driver terminology change proposal

2020-07-14 Thread Marcelo Ricardo Leitner
On Tue, Jul 14, 2020 at 09:17:48PM +0200, Toke Høiland-Jørgensen wrote: > Jarod Wilson writes: > > > As part of an effort to help enact social change, Red Hat is > > committing to efforts to eliminate any problematic terminology from > > any of the software that it ships and supports. Front and c

Re: [RFC] bonding driver terminology change proposal

2020-07-14 Thread Toke Høiland-Jørgensen
Jarod Wilson writes: > As part of an effort to help enact social change, Red Hat is > committing to efforts to eliminate any problematic terminology from > any of the software that it ships and supports. Front and center for > me personally in that effort is the bonding driver's use of the terms

Re: [RFC] bonding driver terminology change proposal

2020-07-14 Thread Jarod Wilson
On Mon, Jul 13, 2020 at 8:55 PM Jay Vosburgh wrote: > > Stephen Hemminger wrote: > > >On Tue, 14 Jul 2020 00:00:16 +0200 > >Michal Kubecek wrote: > > > >> On Mon, Jul 13, 2020 at 02:51:39PM -0400, Jarod Wilson wrote: > >> > To start out with, I'd like to attempt to eliminate as much of the use >

Re: [RFC] bonding driver terminology change proposal

2020-07-14 Thread Jarod Wilson
On Mon, Jul 13, 2020 at 6:00 PM Michal Kubecek wrote: > > On Mon, Jul 13, 2020 at 02:51:39PM -0400, Jarod Wilson wrote: > > To start out with, I'd like to attempt to eliminate as much of the use > > of master and slave in the bonding driver as possible. For the most > > part, I think this can be d

Re: [RFC] bonding driver terminology change proposal

2020-07-14 Thread Jarod Wilson
On Mon, Jul 13, 2020 at 5:36 PM Eric Dumazet wrote: > > On 7/13/20 11:51 AM, Jarod Wilson wrote: > > As part of an effort to help enact social change, Red Hat is > > committing to efforts to eliminate any problematic terminology from > > any of the software that it ships and supports. Front and ce

Re: [RFC] bonding driver terminology change proposal

2020-07-13 Thread David Miller
From: Michal Kubecek Date: Tue, 14 Jul 2020 00:00:16 +0200 > Could we, please, avoid breaking existing userspace tools and scripts? I will not let UAPI breakage, don't worry.

Re: [RFC] bonding driver terminology change proposal

2020-07-13 Thread Jay Vosburgh
Stephen Hemminger wrote: >On Tue, 14 Jul 2020 00:00:16 +0200 >Michal Kubecek wrote: > >> On Mon, Jul 13, 2020 at 02:51:39PM -0400, Jarod Wilson wrote: >> > To start out with, I'd like to attempt to eliminate as much of the use >> > of master and slave in the bonding driver as possible. For the m

Re: [RFC] bonding driver terminology change proposal

2020-07-13 Thread David Miller
From: Jarod Wilson Date: Mon, 13 Jul 2020 14:51:39 -0400 > To start out with, I'd like to attempt to eliminate as much of the use > of master and slave in the bonding driver as possible. For the most > part, I think this can be done without breaking UAPI, but may require > changes to anything acc

Re: [RFC] bonding driver terminology change proposal

2020-07-13 Thread Andrew Lunn
Hi Jarod Do you have this change scripted? Could you apply the script to v5.4 and then cherry-pick the 8 bonding fixes that exist in v5.4.51. How many result in conflicts? Could you do the same with v4.19...v4.19.132, which has 20 fixes. This will give us an idea of the maintenance overhead such

Re: [RFC] bonding driver terminology change proposal

2020-07-13 Thread Michal Kubecek
On Mon, Jul 13, 2020 at 03:41:18PM -0700, Stephen Hemminger wrote: > On Tue, 14 Jul 2020 00:00:16 +0200 > Michal Kubecek wrote: > > > On Mon, Jul 13, 2020 at 02:51:39PM -0400, Jarod Wilson wrote: > > > To start out with, I'd like to attempt to eliminate as much of the use > > > of master and slav

Re: [RFC] bonding driver terminology change proposal

2020-07-13 Thread Stephen Hemminger
On Tue, 14 Jul 2020 00:00:16 +0200 Michal Kubecek wrote: > On Mon, Jul 13, 2020 at 02:51:39PM -0400, Jarod Wilson wrote: > > To start out with, I'd like to attempt to eliminate as much of the use > > of master and slave in the bonding driver as possible. For the most > > part, I think this can be

Re: [RFC] bonding driver terminology change proposal

2020-07-13 Thread Michal Kubecek
On Mon, Jul 13, 2020 at 02:51:39PM -0400, Jarod Wilson wrote: > To start out with, I'd like to attempt to eliminate as much of the use > of master and slave in the bonding driver as possible. For the most > part, I think this can be done without breaking UAPI, but may require > changes to anything

Re: [RFC] bonding driver terminology change proposal

2020-07-13 Thread Eric Dumazet
On 7/13/20 11:51 AM, Jarod Wilson wrote: > As part of an effort to help enact social change, Red Hat is > committing to efforts to eliminate any problematic terminology from > any of the software that it ships and supports. Front and center for > me personally in that effort is the bonding drive

[RFC] bonding driver terminology change proposal

2020-07-13 Thread Jarod Wilson
As part of an effort to help enact social change, Red Hat is committing to efforts to eliminate any problematic terminology from any of the software that it ships and supports. Front and center for me personally in that effort is the bonding driver's use of the terms master and slave, and to a less