On Tue, Oct 1, 2019 at 11:56 PM Toke Høiland-Jørgensen wrote:
>
> Andrii Nakryiko writes:
>
> >> Sure, LGTM! Should we still keep the bit where it expands _opts in the
> >> struct name as part of the macro, or does that become too obtuse?
> >
> > For me it's a question of code navigation. When I'
Andrii Nakryiko writes:
>> Sure, LGTM! Should we still keep the bit where it expands _opts in the
>> struct name as part of the macro, or does that become too obtuse?
>
> For me it's a question of code navigation. When I'll have a code
>
> LIBBPF_OPTS(bpf_object_open, );
>
> I'll want to jump to
On Tue, Oct 1, 2019 at 2:49 PM Toke Høiland-Jørgensen wrote:
>
> Andrii Nakryiko writes:
>
> > On Tue, Oct 1, 2019 at 1:42 AM Toke Høiland-Jørgensen
> > wrote:
> >>
> >> Andrii Nakryiko writes:
> >>
> >> > Add new set of bpf_object__open APIs using new approach to optional
> >> > parameters ex
Andrii Nakryiko writes:
> On Tue, Oct 1, 2019 at 1:42 AM Toke Høiland-Jørgensen wrote:
>>
>> Andrii Nakryiko writes:
>>
>> > Add new set of bpf_object__open APIs using new approach to optional
>> > parameters extensibility allowing simpler ABI compatibility approach.
>> >
>> > This patch demons
On Tue, Oct 1, 2019 at 9:48 AM Jesper Dangaard Brouer wrote:
>
> On Mon, 30 Sep 2019 09:42:39 -0700
> Andrii Nakryiko wrote:
>
> > diff --git a/tools/lib/bpf/libbpf_internal.h
> > b/tools/lib/bpf/libbpf_internal.h
> > index 2e83a34f8c79..1cf2cf8d80f3 100644
> > --- a/tools/lib/bpf/libbpf_interna
On Tue, Oct 1, 2019 at 1:42 AM Toke Høiland-Jørgensen wrote:
>
> Andrii Nakryiko writes:
>
> > Add new set of bpf_object__open APIs using new approach to optional
> > parameters extensibility allowing simpler ABI compatibility approach.
> >
> > This patch demonstrates an approach to implementing
On Mon, 30 Sep 2019 09:42:39 -0700
Andrii Nakryiko wrote:
> diff --git a/tools/lib/bpf/libbpf_internal.h b/tools/lib/bpf/libbpf_internal.h
> index 2e83a34f8c79..1cf2cf8d80f3 100644
> --- a/tools/lib/bpf/libbpf_internal.h
> +++ b/tools/lib/bpf/libbpf_internal.h
> @@ -47,6 +47,12 @@ do {
Andrii Nakryiko writes:
> Add new set of bpf_object__open APIs using new approach to optional
> parameters extensibility allowing simpler ABI compatibility approach.
>
> This patch demonstrates an approach to implementing libbpf APIs that
> makes it easy to extend existing APIs with extra optiona
Add new set of bpf_object__open APIs using new approach to optional
parameters extensibility allowing simpler ABI compatibility approach.
This patch demonstrates an approach to implementing libbpf APIs that
makes it easy to extend existing APIs with extra optional parameters in
such a way, that AB
