Re: [RFC][PATCH 8/9] 3c59x driver conversion

2006-08-13 Thread Jeff Garzik
Daniel Phillips wrote: That is why it has not yet been submitted upstream. Respectfully, I do not think that jgarzik has yet put in the work to know if this anti deadlock technique is reasonable or not, and he was only commenting on some superficial blemish. I still don't get his point, if ther

Re: [RFC][PATCH 8/9] 3c59x driver conversion

2006-08-13 Thread Daniel Phillips
David Miller wrote: I think he's saying that he doesn't think your code is yet a reasonable way to solve the problem, and therefore doesn't belong upstream. That is why it has not yet been submitted upstream. Respectfully, I do not think that jgarzik has yet put in the work to know if this ant

Re: [RFC][PATCH 8/9] 3c59x driver conversion

2006-08-09 Thread Jeff Garzik
Peter Zijlstra wrote: On Wed, 2006-08-09 at 02:30 -0400, Jeff Garzik wrote: David Miller wrote: From: Daniel Phillips <[EMAIL PROTECTED]> Date: Tue, 08 Aug 2006 22:51:20 -0700 Elaborate please. Do you think that all drivers should be updated to fix the broken blockdev semantics, making NETIF

Re: [RFC][PATCH 8/9] 3c59x driver conversion

2006-08-09 Thread Peter Zijlstra
On Wed, 2006-08-09 at 02:30 -0400, Jeff Garzik wrote: > David Miller wrote: > > From: Daniel Phillips <[EMAIL PROTECTED]> > > Date: Tue, 08 Aug 2006 22:51:20 -0700 > > > >> Elaborate please. Do you think that all drivers should be updated to > >> fix the broken blockdev semantics, making NETIF_F_

Re: [RFC][PATCH 8/9] 3c59x driver conversion

2006-08-08 Thread Jeff Garzik
David Miller wrote: From: Daniel Phillips <[EMAIL PROTECTED]> Date: Tue, 08 Aug 2006 22:51:20 -0700 Elaborate please. Do you think that all drivers should be updated to fix the broken blockdev semantics, making NETIF_F_MEMALLOC redundant? If so, I trust you will help audit for it? I think he

Re: [RFC][PATCH 8/9] 3c59x driver conversion

2006-08-08 Thread David Miller
From: Daniel Phillips <[EMAIL PROTECTED]> Date: Tue, 08 Aug 2006 22:51:20 -0700 > Elaborate please. Do you think that all drivers should be updated to > fix the broken blockdev semantics, making NETIF_F_MEMALLOC redundant? > If so, I trust you will help audit for it? I think he's saying that he

Re: [RFC][PATCH 8/9] 3c59x driver conversion

2006-08-08 Thread Daniel Phillips
Jeff Garzik wrote: Peter Zijlstra wrote: Update the driver to make use of the netdev_alloc_skb() API and the NETIF_F_MEMALLOC feature. NETIF_F_MEMALLOC does not exist in the upstream tree... nor should it, IMO. Elaborate please. Do you think that all drivers should be updated to fix the b

Re: [RFC][PATCH 8/9] 3c59x driver conversion

2006-08-08 Thread Jeff Garzik
Peter Zijlstra wrote: Update the driver to make use of the netdev_alloc_skb() API and the NETIF_F_MEMALLOC feature. NETIF_F_MEMALLOC does not exist in the upstream tree... nor should it, IMO. netdev_alloc_skb() is in the tree, and that's fine. Jeff - To unsubscribe from this list:

[RFC][PATCH 8/9] 3c59x driver conversion

2006-08-08 Thread Peter Zijlstra
Update the driver to make use of the netdev_alloc_skb() API and the NETIF_F_MEMALLOC feature. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Signed-off-by: Daniel Phillips <[EMAIL PROTECTED]> --- drivers/net/3c59x.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) Index: l