Re: [RFC][PATCH] net: stmmac: use msleep instead of udelay for gpio reset

2015-04-20 Thread Giuseppe CAVALLARO
On 4/19/2015 6:11 AM, Michael Trimarchi wrote: Hi On Apr 19, 2015 1:37 AM, "Fabio Estevam" mailto:feste...@gmail.com>> wrote: > > On Sat, Apr 18, 2015 at 12:02 PM, Michael Trimarchi > mailto:mich...@amarulasolutions.com>> wrote: > > > reset_gpio = data->reset_gpio; > > -

Re: [RFC][PATCH] net: stmmac: use msleep instead of udelay for gpio reset

2015-04-18 Thread Fabio Estevam
On Sat, Apr 18, 2015 at 12:02 PM, Michael Trimarchi wrote: > reset_gpio = data->reset_gpio; > - active_low = data->active_low; > + active_low = !!data->active_low; This is an unrelated change. -- To unsubscribe from this list: send the line "unsubscrib

[RFC][PATCH] net: stmmac: use msleep instead of udelay for gpio reset

2015-04-18 Thread Michael Trimarchi
Reset delay values are expressed in microsecond but most of the time the delay is more then 2ms and up to 100ms. Use udelay is wrong for large sleep period. This function is not used in interrupt context according to the documentation. Signed-off-by: Michael Trimarchi --- drivers/net/ethernet/st