Re: [RFC/PATCH 1/2] is_multicast_ether_addr() should include the broadcast address

2005-12-16 Thread John W. Linville
On Fri, Dec 16, 2005 at 12:47:47AM -0800, Nivedita Singhvi wrote: > Stephen Hemminger wrote: > > >On Thu, 15 Dec 2005 21:10:03 -0500 > >"John W. Linville" <[EMAIL PROTECTED]> wrote: > >>That is a good question...what does a MAC address like > >>FF:xx:xx:xx:xx:xx signify? Anyone know? > > > > > >

Re: [RFC/PATCH 1/2] is_multicast_ether_addr() should include the broadcast address

2005-12-16 Thread Nivedita Singhvi
Stephen Hemminger wrote: On Thu, 15 Dec 2005 21:10:03 -0500 "John W. Linville" <[EMAIL PROTECTED]> wrote: On Thu, Dec 15, 2005 at 06:54:21PM -0600, Michael Ellerman wrote: + /* XXX Why are we checking for 0xff here ? */ + return (addr[0] == 0xff) || (!is_multicast_ether_addr(ad

Re: [RFC/PATCH 1/2] is_multicast_ether_addr() should include the broadcast address

2005-12-15 Thread Stephen Hemminger
On Thu, 15 Dec 2005 21:10:03 -0500 "John W. Linville" <[EMAIL PROTECTED]> wrote: > On Thu, Dec 15, 2005 at 06:54:21PM -0600, Michael Ellerman wrote: > > > + /* XXX Why are we checking for 0xff here ? */ > > + return (addr[0] == 0xff) || (!is_multicast_ether_addr(addr) > > + && !is_z

Re: [RFC/PATCH 1/2] is_multicast_ether_addr() should include the broadcast address

2005-12-15 Thread John W. Linville
On Thu, Dec 15, 2005 at 06:54:21PM -0600, Michael Ellerman wrote: > + /* XXX Why are we checking for 0xff here ? */ > + return (addr[0] == 0xff) || (!is_multicast_ether_addr(addr) > + && !is_zero_ether_addr(addr)); That is a good question...what does a MAC address like FF:xx:x

[RFC/PATCH 1/2] is_multicast_ether_addr() should include the broadcast address

2005-12-15 Thread Michael Ellerman
Everything I've found on the 'net says that any MAC address with 0x1 in byte 0 is a multicast address. Which obviously includes the broadcast address. I think is_multicast_ether_addr() should implement that logic, if not we should call it something else, otherwise we're asking for confusion. I've